Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: src/parsing/parser.cc

Issue 2517143003: Remove some leftovers of full-codegen's generators implementation. (Closed)
Patch Set: GENERATOR_CONTINUATION in arm64 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/objects.cc ('K') | « src/objects.cc ('k') | src/ppc/assembler-ppc.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/parser.cc
diff --git a/src/parsing/parser.cc b/src/parsing/parser.cc
index 79d06da50750fca179203bb8abd768b07043d76d..e67763f8e69c518577e079df0e10cc7ef2c927d7 100644
--- a/src/parsing/parser.cc
+++ b/src/parsing/parser.cc
@@ -2488,10 +2488,10 @@ void Parser::ReindexLiterals(const ParserFormalParameters& parameters) {
}
void Parser::PrepareGeneratorVariables(FunctionState* function_state) {
- // For generators, allocating variables in contexts is currently a win
- // because it minimizes the work needed to suspend and resume an
- // activation. The machine code produced for generators (by full-codegen)
- // relies on this forced context allocation, but not in an essential way.
+ // For generators, allocating variables in contexts is currently a win because
+ // it minimizes the work needed to suspend and resume an activation. The
+ // machine code produced for generators relies on this forced context
Michael Starzinger 2016/11/21 15:56:16 nit: s/machine code/code/ here because it is techn
neis 2016/11/22 13:18:53 Done.
+ // allocation, but not in an essential way.
scope()->ForceContextAllocation();
// Calling a generator returns a generator object. That object is stored
« src/objects.cc ('K') | « src/objects.cc ('k') | src/ppc/assembler-ppc.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698