Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2517143002: [test] Run module tests in all variants. (Closed)

Created:
4 years, 1 month ago by Michael Starzinger
Modified:
4 years, 1 month ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Run module tests in all variants. By now the compilation pipeline is flexible enough to run module tests against all variants, we should no longer choose unsupported compilers for modules. It also fixes the predicate checking for functions being "resumable" in the {AstNumberingVisitor} heuristic. R=neis@chromium.org BUG=v8:1569 Committed: https://crrev.com/2e5a90fd024f9cf70b8fc5b55aee2c1f574288d3 Cr-Commit-Position: refs/heads/master@{#41144}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -44 lines) Patch
M src/ast/ast-numbering.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -7 lines 0 comments Download
M test/mjsunit/mjsunit.status View 2 chunks +4 lines, -7 lines 0 comments Download
M test/test262/test262.status View 2 chunks +17 lines, -29 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Michael Starzinger
4 years, 1 month ago (2016-11-21 13:40:42 UTC) #1
neis
nice, lgtm.
4 years, 1 month ago (2016-11-21 13:48:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517143002/1
4 years, 1 month ago (2016-11-21 14:16:41 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 14:18:21 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 14:18:40 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e5a90fd024f9cf70b8fc5b55aee2c1f574288d3
Cr-Commit-Position: refs/heads/master@{#41144}

Powered by Google App Engine
This is Rietveld 408576698