Issue 251713002: web_dev_style: add check for ending jsdoc comments with **/ instead of */.

Issue 251713002: web_dev_style: add check for ending jsdoc comments with **/ instead of */. (Closed)

Created:
6 years, 8 months ago by Dan Beam

Modified:
6 years, 7 months ago

Reviewers:
Tyler Breisacher (Chromium)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

web_dev_style: add check for ending jsdoc comments with **/ instead of */. R=tbreisacher@chromium.org BUG=366972 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266430

Patch Set 3 : upstream => master #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -0 lines)			Patch
	M	chrome/browser/resources/test_presubmit.py	View	1 2	1 chunk	+33 lines, -0 lines	0 comments	Download
	M	chrome/browser/resources/web_dev_style/js_checker.py	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Dan Beam

depends on: https://chromiumcodereview.appspot.com/255503006/ https://chromiumcodereview.appspot.com/253543002/

6 years, 8 months ago (2014-04-25 02:03:12 UTC) #1

Tyler Breisacher (Chromium)

lgtm https://chromiumcodereview.appspot.com/251713002/diff/20001/chrome/browser/web_dev_style/js_checker.py File chrome/browser/web_dev_style/js_checker.py (right): https://chromiumcodereview.appspot.com/251713002/diff/20001/chrome/browser/web_dev_style/js_checker.py#newcode57 chrome/browser/web_dev_style/js_checker.py:57: return _check(r'^\s*(\*\*/)\s*$') or _check(r'\/\*\* @[a-zA-Z]+.* (\*\*/)') Instead of ...

6 years, 8 months ago (2014-04-25 22:50:42 UTC) #2

Dan Beam

https://chromiumcodereview.appspot.com/251713002/diff/20001/chrome/browser/web_dev_style/js_checker.py File chrome/browser/web_dev_style/js_checker.py (right): https://chromiumcodereview.appspot.com/251713002/diff/20001/chrome/browser/web_dev_style/js_checker.py#newcode57 chrome/browser/web_dev_style/js_checker.py:57: return _check(r'^\s*(\*\*/)\s*$') or _check(r'\/\*\* @[a-zA-Z]+.* (\*\*/)') On 2014/04/25 22:50:43, ...

6 years, 8 months ago (2014-04-26 01:14:37 UTC) #3

Dan Beam

On 2014/04/25 02:03:12, Dan Beam wrote: > depends on: > https://chromiumcodereview.appspot.com/255503006/ > https://chromiumcodereview.appspot.com/253543002/ nvm, removed ...

6 years, 8 months ago (2014-04-26 02:48:27 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/251713002/50001

6 years, 8 months ago (2014-04-26 02:49:59 UTC) #6

Message was sent while issue was closed.

Change committed as 266430

Expand Messages | Collapse Messages