Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2517113004: Don't use deprecated ScriptOrigin cstor in V8ScriptRunner (Closed)

Created:
4 years, 1 month ago by kozy
Modified:
4 years, 1 month ago
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, kozyatinskiy+blink_chromium.org, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use deprecated ScriptOrigin cstor in V8ScriptRunner is_embbder_debugger_script was deprecated and will be remove soon from public API. Inspector was moved to V8 and could use internal API to mark scripts. BUG=chromium:666142 R=dgozman@chromium.org Committed: https://crrev.com/e9f66a006042a24089a0cf4e86f1d8ea978f8038 Cr-Commit-Position: refs/heads/master@{#433653}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -14 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-error-on-call-frame-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-while-paused-throws-expected.txt View 1 chunk +8 lines, -8 lines 1 comment Download
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
kozy
Dmitry, please take a look.
4 years, 1 month ago (2016-11-21 18:08:00 UTC) #1
dgozman
https://codereview.chromium.org/2517113004/diff/1/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-while-paused-throws-expected.txt File third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-while-paused-throws-expected.txt (right): https://codereview.chromium.org/2517113004/diff/1/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-while-paused-throws-expected.txt#newcode10 third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-while-paused-throws-expected.txt:10: at eval (eval at testFunction (debugger-eval-while-paused-throws.html:18), <anonymous>:1:1) Why does ...
4 years, 1 month ago (2016-11-21 18:55:56 UTC) #2
dgozman
lgtm, but let's follow up with incorrect evaluate on call frame attribution
4 years, 1 month ago (2016-11-21 19:09:18 UTC) #3
kozy
Pavel, please take a look. I need your owner lgtm.
4 years, 1 month ago (2016-11-21 19:49:53 UTC) #6
pfeldman
lgtm
4 years, 1 month ago (2016-11-21 19:51:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517113004/1
4 years, 1 month ago (2016-11-21 19:58:21 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 21:13:57 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e9f66a006042a24089a0cf4e86f1d8ea978f8038 Cr-Commit-Position: refs/heads/master@{#433653}
4 years, 1 month ago (2016-11-21 21:16:31 UTC) #17
Michael Achenbach
4 years, 1 month ago (2016-11-22 07:41:39 UTC) #19

Powered by Google App Engine
This is Rietveld 408576698