Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2517083002: Enable MD storage manager by default. (Closed)

Created:
4 years, 1 month ago by fukino
Modified:
4 years ago
Reviewers:
michaelpg
CC:
chromium-reviews, oshima+watch_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, asvitkine+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable MD storage manager by default. The storage manager in MD settings was behind a flag. As M56 has been branched, it should be a good timing to flip the flag and remove the code related to the flag. BUG=629438 TEST=manually tested CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/48f133740b2b18a790e54c843db8fbfc6b57ddfe Cr-Commit-Position: refs/heads/master@{#434441}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -44 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 3 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/device_page/device_page.html View 2 chunks +12 lines, -16 lines 0 comments Download
M chrome/browser/resources/settings/device_page/device_page.js View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 26 (16 generated)
fukino
michaelpg@, could you take a look?
4 years, 1 month ago (2016-11-21 08:54:42 UTC) #4
michaelpg
lgtm
4 years, 1 month ago (2016-11-21 21:53:53 UTC) #9
fukino
On 2016/11/21 21:53:53, michaelpg wrote: > lgtm Thanks!
4 years, 1 month ago (2016-11-22 04:17:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517083002/1
4 years, 1 month ago (2016-11-22 04:17:37 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/310210)
4 years, 1 month ago (2016-11-22 04:23:58 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517083002/20001
4 years ago (2016-11-24 00:48:17 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) cast_shell_linux on ...
4 years ago (2016-11-24 02:50:13 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517083002/20001
4 years ago (2016-11-25 05:17:25 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-25 06:18:11 UTC) #24
commit-bot: I haz the power
4 years ago (2016-11-25 06:21:14 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/48f133740b2b18a790e54c843db8fbfc6b57ddfe
Cr-Commit-Position: refs/heads/master@{#434441}

Powered by Google App Engine
This is Rietveld 408576698