Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2517043002: Add a UseCounter for '>>>' combinator. (Closed)

Created:
4 years, 1 month ago by kochi
Modified:
4 years, 1 month ago
Reviewers:
haraken, hayato
CC:
darktears, apavlov+blink_chromium.org, asvitkine+watch_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a UseCounter for '>>>' combinator. BUG=633007 TBR=haraken@chromium.org for histograms.xml Committed: https://crrev.com/ea3f73b7066df2f90e2ea56d280f6646760d4f35 Cr-Commit-Position: refs/heads/master@{#433484}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
kochi
PTAL
4 years, 1 month ago (2016-11-21 03:19:41 UTC) #3
hayato
lgtm
4 years, 1 month ago (2016-11-21 04:38:50 UTC) #6
kochi
haraken-san, could you review this for histograms.xml?
4 years, 1 month ago (2016-11-21 05:11:24 UTC) #10
haraken
On 2016/11/21 05:11:24, kochi wrote: > haraken-san, could you review this for histograms.xml? LGTM
4 years, 1 month ago (2016-11-21 05:20:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517043002/1
4 years, 1 month ago (2016-11-21 05:28:23 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 06:26:02 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 06:29:15 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea3f73b7066df2f90e2ea56d280f6646760d4f35
Cr-Commit-Position: refs/heads/master@{#433484}

Powered by Google App Engine
This is Rietveld 408576698