Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 251703004: Do not set kGoogleServicesUsername for device-local accounts (Closed)

Created:
6 years, 8 months ago by bartfab (slow)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Do not set kGoogleServicesUsername for device-local accounts The kGoogleServicesUsername pref indicates that Chrome is signed in with a GAIA account. Since device-local accounts do not have GAIA credentials, this pref should not be set for them. BUG=327849 TEST=Extended browser tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266529

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -3 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 4 chunks +21 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
bartfab (slow)
Hi Nikita, Could you please take a look at this CL? Hi Mattias, Could you ...
6 years, 8 months ago (2014-04-25 12:05:45 UTC) #1
bartfab (slow)
Hi Nikita, Could you please take a look at this CL? Hi Mattias, Could you ...
6 years, 8 months ago (2014-04-25 12:06:03 UTC) #2
Mattias Nissler (ping if slow)
LGTM
6 years, 8 months ago (2014-04-25 12:07:28 UTC) #3
Nikita (slow)
lgtm
6 years, 7 months ago (2014-04-28 08:23:04 UTC) #4
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 7 months ago (2014-04-28 08:43:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/251703004/1
6 years, 7 months ago (2014-04-28 08:44:28 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 10:01:52 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-28 10:01:52 UTC) #8
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 7 months ago (2014-04-28 12:16:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/251703004/1
6 years, 7 months ago (2014-04-28 12:16:43 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 12:38:53 UTC) #11
Message was sent while issue was closed.
Change committed as 266529

Powered by Google App Engine
This is Rietveld 408576698