Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2517023002: Revert of Minor style changes to HarfBuzzShaper to improve readability (Closed)

Created:
4 years, 1 month ago by Matt Giuca
Modified:
4 years, 1 month ago
Reviewers:
szager1, eae
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Minor style changes to HarfBuzzShaper to improve readability (patchset #1 id:1 of https://codereview.chromium.org/2513473007/ ) Reason for revert: Appears to have broken HarfBuzzShaperTest.ResolveCandidateRunsUnicodeVariants on Linux ASan. BUG=667147 Original issue's description: > Minor style changes to HarfBuzzShaper to improve readability > > TBR=szager@chromium.org > > Committed: https://crrev.com/95b18a0f83f57c597c435e09b4081d995e0defe0 > Cr-Commit-Position: refs/heads/master@{#433265} TBR=szager@chromium.org,eae@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/c4c4fd40e57affab6a53322119636a09aed77c55 Cr-Commit-Position: refs/heads/master@{#433469}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -30 lines) Patch
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp View 8 chunks +37 lines, -30 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Matt Giuca
Created Revert of Minor style changes to HarfBuzzShaper to improve readability
4 years, 1 month ago (2016-11-21 00:53:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517023002/1
4 years, 1 month ago (2016-11-21 00:53:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 02:20:21 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c4c4fd40e57affab6a53322119636a09aed77c55 Cr-Commit-Position: refs/heads/master@{#433469}
4 years, 1 month ago (2016-11-21 02:24:33 UTC) #8
eae
4 years, 1 month ago (2016-11-21 16:25:59 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2517193002/ by eae@chromium.org.

The reason for reverting is: Was't the cause of the regression, see bug 667147..

Powered by Google App Engine
This is Rietveld 408576698