Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1921)

Issue 2517013002: [chromecast] Removes redundant DEPS rules. (Closed)

Created:
4 years, 1 month ago by alokp
Modified:
4 years, 1 month ago
Reviewers:
slan
CC:
chromium-reviews, sadrul, lcwu+watch_chromium.org, feature-media-reviews_chromium.org, halliwell+watch_chromium.org, alokp+watch_chromium.org, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromecast] Removes redundant DEPS rules. BUG=665489 Committed: https://crrev.com/4941d96885a43a53b6ae84eaea345f61339bbcef Cr-Commit-Position: refs/heads/master@{#433678}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chromecast/crash/linux/DEPS View 1 chunk +0 lines, -1 line 2 comments Download
M chromecast/graphics/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D chromecast/media/cma/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
alokp
4 years, 1 month ago (2016-11-20 23:08:43 UTC) #2
slan
lgtm % 1 question https://codereview.chromium.org/2517013002/diff/1/chromecast/crash/linux/DEPS File chromecast/crash/linux/DEPS (left): https://codereview.chromium.org/2517013002/diff/1/chromecast/crash/linux/DEPS#oldcode2 chromecast/crash/linux/DEPS:2: "+chromecast/crash", Does this work? I ...
4 years, 1 month ago (2016-11-21 22:08:21 UTC) #3
alokp
https://codereview.chromium.org/2517013002/diff/1/chromecast/crash/linux/DEPS File chromecast/crash/linux/DEPS (left): https://codereview.chromium.org/2517013002/diff/1/chromecast/crash/linux/DEPS#oldcode2 chromecast/crash/linux/DEPS:2: "+chromecast/crash", On 2016/11/21 22:08:21, slan wrote: > Does this ...
4 years, 1 month ago (2016-11-21 22:34:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517013002/1
4 years, 1 month ago (2016-11-21 22:34:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 22:47:02 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4941d96885a43a53b6ae84eaea345f61339bbcef Cr-Commit-Position: refs/heads/master@{#433678}
4 years, 1 month ago (2016-11-21 22:49:19 UTC) #10
slan
On 2016/11/21 22:34:23, alokp wrote: > https://codereview.chromium.org/2517013002/diff/1/chromecast/crash/linux/DEPS > File chromecast/crash/linux/DEPS (left): > > https://codereview.chromium.org/2517013002/diff/1/chromecast/crash/linux/DEPS#oldcode2 > ...
4 years, 1 month ago (2016-11-21 23:07:15 UTC) #11
slan
4 years, 1 month ago (2016-11-21 23:07:15 UTC) #12
Message was sent while issue was closed.
On 2016/11/21 22:34:23, alokp wrote:
> https://codereview.chromium.org/2517013002/diff/1/chromecast/crash/linux/DEPS
> File chromecast/crash/linux/DEPS (left):
> 
>
https://codereview.chromium.org/2517013002/diff/1/chromecast/crash/linux/DEPS...
> chromecast/crash/linux/DEPS:2: "+chromecast/crash",
> On 2016/11/21 22:08:21, slan wrote:
> > Does this work? I see some files that need includes from the parent dir. One
> > example:
> > 
> >
>
https://cs.chromium.org/chromium/src/chromecast/crash/linux/minidump_uploader...
> 
> You do not need to explicitly include parent directories unless the parent
> directory DEPS disallows it.

TIL; thanks

Powered by Google App Engine
This is Rietveld 408576698