webrtc/modules/audio_coding/codecs/audio_decoder_factory_unittest.cc - Issue 2516993002: Pass SdpAudioFormat through Channel, without converting to CodecInst

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/audio_decoder_factory_unittest.cc

Issue 2516993002: Pass SdpAudioFormat through Channel, without converting to CodecInst (Closed)

Patch Set: add TODO Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/codecs/audio_decoder_factory.h ('k') | webrtc/modules/audio_coding/codecs/audio_format.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/audio_decoder_factory_unittest.cc

diff --git a/webrtc/modules/audio_coding/codecs/audio_decoder_factory_unittest.cc b/webrtc/modules/audio_coding/codecs/audio_decoder_factory_unittest.cc

index 6b63f987f09207357f191e8ef0478a0d1380dcf1..0379613703ce57db617d70f56d22f6fb16c5af77 100644

--- a/webrtc/modules/audio_coding/codecs/audio_decoder_factory_unittest.cc

+++ b/webrtc/modules/audio_coding/codecs/audio_decoder_factory_unittest.cc

@@ -122,8 +122,8 @@ TEST(AudioDecoderFactoryTest, CreateOpus) {

if (stereo != "XX") {

params["stereo"] = stereo;

}

- bool good =

- (hz == 48000 && channels == 2 && (stereo == "0" || stereo == "1"));

+ const bool good = (hz == 48000 && channels == 2 &&

+ (stereo == "XX" || stereo == "0" || stereo == "1"));

EXPECT_EQ(good, static_cast<bool>(adf->MakeAudioDecoder(SdpAudioFormat(

"opus", hz, channels, std::move(params)))));

}

« no previous file with comments | « webrtc/modules/audio_coding/codecs/audio_decoder_factory.h ('k') | webrtc/modules/audio_coding/codecs/audio_format.h » ('j') | no next file with comments »