Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2516983003: WPT: Request to import domparsing, domxpath, and innerText. (Closed)

Created:
4 years, 1 month ago by tkent
Modified:
4 years ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WPT: Request to import domparsing, domxpath, and innerText. BUG=651752, 651757, 573309 NOTRY=true Committed: https://crrev.com/63d26d050ffc4707fabaef0cac4206f8118cea45 Cr-Commit-Position: refs/heads/master@{#433500}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/W3CImportExpectations View 2 chunks +6 lines, -3 lines 2 comments Download

Messages

Total messages: 14 (6 generated)
tkent
kochi@, would you review this please?
4 years, 1 month ago (2016-11-21 08:43:29 UTC) #3
kochi
lgtm
4 years, 1 month ago (2016-11-21 09:45:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516983003/1
4 years, 1 month ago (2016-11-21 09:48:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 09:52:25 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/63d26d050ffc4707fabaef0cac4206f8118cea45 Cr-Commit-Position: refs/heads/master@{#433500}
4 years, 1 month ago (2016-11-21 09:55:26 UTC) #10
Marijn Kruisselbrink
https://codereview.chromium.org/2516983003/diff/1/third_party/WebKit/LayoutTests/W3CImportExpectations File third_party/WebKit/LayoutTests/W3CImportExpectations (right): https://codereview.chromium.org/2516983003/diff/1/third_party/WebKit/LayoutTests/W3CImportExpectations#newcode230 third_party/WebKit/LayoutTests/W3CImportExpectations:230: # imported/wpt/domxpath [ Pass ] This made it impossible ...
4 years ago (2016-11-29 23:29:20 UTC) #12
tkent
https://codereview.chromium.org/2516983003/diff/1/third_party/WebKit/LayoutTests/W3CImportExpectations File third_party/WebKit/LayoutTests/W3CImportExpectations (right): https://codereview.chromium.org/2516983003/diff/1/third_party/WebKit/LayoutTests/W3CImportExpectations#newcode230 third_party/WebKit/LayoutTests/W3CImportExpectations:230: # imported/wpt/domxpath [ Pass ] On 2016/11/29 at 23:29:20, ...
4 years ago (2016-11-30 00:51:03 UTC) #13
tkent
4 years ago (2016-11-30 02:07:32 UTC) #14
Message was sent while issue was closed.
On 2016/11/30 at 00:51:03, tkent wrote:
> > # err> UnicodeEncodeError: 'ascii' codec can't encode character u'\xf8' in
position 5: ordinal not in range(128)
> 
> Thanks.  I'll disable domxpath/xml_xpath_tests.xml.

Oops, xml_xpath_tests.xml was innocent.  001.html and 002.html were culprits.

Powered by Google App Engine
This is Rietveld 408576698