|
|
Chromium Code Reviews
DescriptionWPT: Request to import domparsing, domxpath, and innerText.
BUG=651752, 651757, 573309
NOTRY=true
Committed: https://crrev.com/63d26d050ffc4707fabaef0cac4206f8118cea45
Cr-Commit-Position: refs/heads/master@{#433500}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 14 (6 generated)
Description was changed from ========== WPT: Request to import domparsing, domxpath, and innerText. BUG=651752, 651757, 573309 ========== to ========== WPT: Request to import domparsing, domxpath, and innerText. BUG=651752, 651757, 573309 NOTRY=true ==========
tkent@chromium.org changed reviewers: + kochi@chromium.org
kochi@, would you review this please?
lgtm
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1479721696627250, "parent_rev":
["d8c207fbe0126a3b91c5fc24cf32a16d3ce03915", null], "commit_rev":
["84f30584640e34de5efadfe80526e04936494887", null]}
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== WPT: Request to import domparsing, domxpath, and innerText. BUG=651752, 651757, 573309 NOTRY=true ========== to ========== WPT: Request to import domparsing, domxpath, and innerText. BUG=651752, 651757, 573309 NOTRY=true Committed: https://crrev.com/63d26d050ffc4707fabaef0cac4206f8118cea45 Cr-Commit-Position: refs/heads/master@{#433500} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/63d26d050ffc4707fabaef0cac4206f8118cea45 Cr-Commit-Position: refs/heads/master@{#433500}
Message was sent while issue was closed.
mek@chromium.org changed reviewers: + mek@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/2516983003/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/W3CImportExpectations (right): https://codereview.chromium.org/2516983003/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/W3CImportExpectations:230: # imported/wpt/domxpath [ Pass ] This made it impossible to do any imports of wpt, as there are tests in domxpath that cause the import script to crash: # err> Traceback (most recent call last): # err> File "/usr/local/google_ssd/mek/src/third_party/WebKit/Tools/Scripts/import-w3c-tests", line 35, in <module> # err> sys.exit(test_importer.main(sys.argv[1:], sys.stdout, sys.stderr)) # err> File "/usr/local/google_ssd/mek/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 99, in main # err> test_importer.do_import() # err> File "/usr/local/google_ssd/mek/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 167, in do_import # err> self.find_importable_tests() # err> File "/usr/local/google_ssd/mek/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 246, in find_importable_tests # err> test_parser = TestParser(fullpath, self.host) # err> File "/usr/local/google_ssd/mek/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser.py", line 47, in __init__ # err> self.load_file(filename) # err> File "/usr/local/google_ssd/mek/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser.py", line 53, in load_file # err> doc = BeautifulSoup(self.filesystem.read_binary_file(filename)) # err> File "/usr/local/google_ssd/mek/src/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/BeautifulSoup.py", line 1519, in __init__ # err> BeautifulStoneSoup.__init__(self, *args, **kwargs) # err> File "/usr/local/google_ssd/mek/src/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/BeautifulSoup.py", line 1144, in __init__ # err> self._feed(isHTML=isHTML) # err> File "/usr/local/google_ssd/mek/src/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/BeautifulSoup.py", line 1186, in _feed # err> SGMLParser.feed(self, markup) # err> File "/usr/lib/python2.7/sgmllib.py", line 104, in feed # err> self.goahead(0) # err> File "/usr/lib/python2.7/sgmllib.py", line 143, in goahead # err> k = self.parse_endtag(i) # err> File "/usr/lib/python2.7/sgmllib.py", line 320, in parse_endtag # err> self.finish_endtag(tag) # err> File "/usr/lib/python2.7/sgmllib.py", line 358, in finish_endtag # err> method = getattr(self, 'end_' + tag) # err> UnicodeEncodeError: 'ascii' codec can't encode character u'\xf8' in position 5: ordinal not in range(128)
Message was sent while issue was closed.
https://codereview.chromium.org/2516983003/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/W3CImportExpectations (right): https://codereview.chromium.org/2516983003/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/W3CImportExpectations:230: # imported/wpt/domxpath [ Pass ] On 2016/11/29 at 23:29:20, Marijn Kruisselbrink wrote: > This made it impossible to do any imports of wpt, as there are tests in domxpath that cause the import script to crash: > > # err> Traceback (most recent call last): > # err> File "/usr/local/google_ssd/mek/src/third_party/WebKit/Tools/Scripts/import-w3c-tests", line 35, in <module> > # err> sys.exit(test_importer.main(sys.argv[1:], sys.stdout, sys.stderr)) > # err> File "/usr/local/google_ssd/mek/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 99, in main > # err> test_importer.do_import() > # err> File "/usr/local/google_ssd/mek/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 167, in do_import > # err> self.find_importable_tests() > # err> File "/usr/local/google_ssd/mek/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 246, in find_importable_tests > # err> test_parser = TestParser(fullpath, self.host) > # err> File "/usr/local/google_ssd/mek/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser.py", line 47, in __init__ > # err> self.load_file(filename) > # err> File "/usr/local/google_ssd/mek/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser.py", line 53, in load_file > # err> doc = BeautifulSoup(self.filesystem.read_binary_file(filename)) > # err> File "/usr/local/google_ssd/mek/src/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/BeautifulSoup.py", line 1519, in __init__ > # err> BeautifulStoneSoup.__init__(self, *args, **kwargs) > # err> File "/usr/local/google_ssd/mek/src/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/BeautifulSoup.py", line 1144, in __init__ > # err> self._feed(isHTML=isHTML) > # err> File "/usr/local/google_ssd/mek/src/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/BeautifulSoup.py", line 1186, in _feed > # err> SGMLParser.feed(self, markup) > # err> File "/usr/lib/python2.7/sgmllib.py", line 104, in feed > # err> self.goahead(0) > # err> File "/usr/lib/python2.7/sgmllib.py", line 143, in goahead > # err> k = self.parse_endtag(i) > # err> File "/usr/lib/python2.7/sgmllib.py", line 320, in parse_endtag > # err> self.finish_endtag(tag) > # err> File "/usr/lib/python2.7/sgmllib.py", line 358, in finish_endtag > # err> method = getattr(self, 'end_' + tag) > # err> UnicodeEncodeError: 'ascii' codec can't encode character u'\xf8' in position 5: ordinal not in range(128) Thanks. I'll disable domxpath/xml_xpath_tests.xml.
Message was sent while issue was closed.
On 2016/11/30 at 00:51:03, tkent wrote: > > # err> UnicodeEncodeError: 'ascii' codec can't encode character u'\xf8' in position 5: ordinal not in range(128) > > Thanks. I'll disable domxpath/xml_xpath_tests.xml. Oops, xml_xpath_tests.xml was innocent. 001.html and 002.html were culprits. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
