Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2516973006:
Remove unused histogram count. (Closed)
|
Created:
4 years, 1 month ago by pastarmovj Modified:
4 years ago Reviewers:
anthonyvd CC:
chromium-reviews, rginda+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove unused histogram count.
It has been added in the code in 2013 and has never been added to the
histograms.xml file so presumable nobody has ever cared about its value.
BUG=643542
TEST=none
Committed: https://crrev.com/2e7df988d039c10d7adce428a762dc13ef3812a0
Cr-Commit-Position: refs/heads/master@{#434355}
Patch Set 1 #
Messages
Total messages: 21 (10 generated)
pastarmovj@chromium.org changed reviewers: + anthonyvd@chromium.org
Hi, can you please review this CL? It's a small clean-up long overdue :) Best, Julian
lgtm
The CQ bit was checked by pastarmovj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by pastarmovj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by pastarmovj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by pastarmovj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480006212102050, "parent_rev":
"e8ff5a73309e9b4b82b992aa61be59d410edbe38", "commit_rev":
"b57fa03c56b5b00489cd650d0244a083267637e2"}
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove unused histogram count. It has been added in the code in 2013 and has never been added to the histograms.xml file so presumable nobody has ever cared about its value. BUG=643542 TEST=none ========== to ========== Remove unused histogram count. It has been added in the code in 2013 and has never been added to the histograms.xml file so presumable nobody has ever cared about its value. BUG=643542 TEST=none Committed: https://crrev.com/2e7df988d039c10d7adce428a762dc13ef3812a0 Cr-Commit-Position: refs/heads/master@{#434355} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/2e7df988d039c10d7adce428a762dc13ef3812a0 Cr-Commit-Position: refs/heads/master@{#434355} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
