Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2516943002: mus-gpu: Fix a couple of issues with MojoGpuMemoryBufferManager. (Closed)

Created:
4 years, 1 month ago by sadrul
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, piman+watch_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus-gpu: Fix a couple of issues with MojoGpuMemoryBufferManager. . Make sure the weak pointer is checked and invalidated in the correct thread. To do this: initialize the weak pointer in the memory thread, so that it can then be used to create a callback in any thread. But make sure this callback is checked in the same memory thread. . Take a connection to mojom::GpuService as an input to the constructor, instead of getting the connection from the service_manager. This will be necessary when the connections are created by InterfaceProvider instead of by Connector (when running in chrome-renderer). BUG=643746 Committed: https://crrev.com/a43aec3076a466005383d7db0d6926951c6f1623 Cr-Commit-Position: refs/heads/master@{#433593}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -15 lines) Patch
M services/ui/public/cpp/gpu/gpu_service.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M services/ui/public/cpp/gpu/mojo_gpu_memory_buffer_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M services/ui/public/cpp/gpu/mojo_gpu_memory_buffer_manager.cc View 4 chunks +25 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
sadrul
4 years, 1 month ago (2016-11-21 01:10:46 UTC) #7
sky
LGTM
4 years, 1 month ago (2016-11-21 16:43:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516943002/1
4 years, 1 month ago (2016-11-21 17:41:15 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 18:35:43 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 18:39:14 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a43aec3076a466005383d7db0d6926951c6f1623
Cr-Commit-Position: refs/heads/master@{#433593}

Powered by Google App Engine
This is Rietveld 408576698