Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2516883003: mus-gpu: Allow connection request to gpu to fail. (Closed)

Created:
4 years, 1 month ago by sadrul
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, sky
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, piman+watch_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus-gpu: Allow connection request to gpu to fail. It is possible for the gpu-host (i.e. window-server) to fail to set up connection to the gpu for the client. Allow the client to be notified about this correctly. BUG=643746 Committed: https://crrev.com/2e790171a1806ea15a81ef9bc2ab87ec93aabb92 Cr-Commit-Position: refs/heads/master@{#433648}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M services/ui/public/cpp/gpu/gpu_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/public/interfaces/gpu_service.mojom View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
sadrul
tsepez@ for mojom change. sky@ for the .cc change
4 years, 1 month ago (2016-11-20 03:16:28 UTC) #4
sky
LGTM
4 years, 1 month ago (2016-11-21 16:19:37 UTC) #7
Tom Sepez
lgtm
4 years, 1 month ago (2016-11-21 18:13:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516883003/1
4 years, 1 month ago (2016-11-21 18:18:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 21:04:53 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 21:08:10 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e790171a1806ea15a81ef9bc2ab87ec93aabb92
Cr-Commit-Position: refs/heads/master@{#433648}

Powered by Google App Engine
This is Rietveld 408576698