Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 2516833002: DevTools: launch worker runtimes with all the queryParams of the main page runtime. (Closed)

Created:
4 years, 1 month ago by lushnikov
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: launch worker runtimes with all the queryParams of the main page runtime. In order to properly load modules, Runtime relies on a few queryParam flags. One of them, remoteBase, was successfully passed to the worker runtimes. Another one, debugFrontend, wasn't. As a result, the remote modules were not loaded properly in workers for the debugDevtools front-ends. This patch passes all the queryParams to the worker runtime. BUG=666946 R=dgozman Committed: https://crrev.com/178617ce268c8d8e5a19f46e43d239b76a117752 Cr-Commit-Position: refs/heads/master@{#433656}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/Runtime.js View 2 chunks +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/Worker.js View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
lushnikov
please, take a look
4 years, 1 month ago (2016-11-19 01:42:33 UTC) #1
dgozman
lgtm
4 years, 1 month ago (2016-11-21 19:16:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516833002/1
4 years, 1 month ago (2016-11-21 19:34:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 21:30:37 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 21:34:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/178617ce268c8d8e5a19f46e43d239b76a117752
Cr-Commit-Position: refs/heads/master@{#433656}

Powered by Google App Engine
This is Rietveld 408576698