Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 251683005: add 4 unittests to chrome_tests.py (Closed)

Created:
6 years, 8 months ago by zhaoqin
Modified:
6 years, 8 months ago
Reviewers:
Nico, Derek Bruening
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

add 4 unittests to chrome_tests.py - add cloud_print_unittests, cacheinvalidation_unittest, libaddressinput_unittests, and libphonenumber_unittests to chrome_tests.py so they can run under Valgrind or Dr.Memory. R=bruening@chromium.org, thakis@chromium.org NOTRY=true BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266321

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M tools/valgrind/chrome_tests.py View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
zhaoqin
6 years, 8 months ago (2014-04-25 20:47:49 UTC) #1
Derek Bruening
LGTM
6 years, 8 months ago (2014-04-25 21:44:03 UTC) #2
Nico
lgtm
6 years, 8 months ago (2014-04-25 21:45:08 UTC) #3
zhaoqin
The CQ bit was checked by zhaoqin@google.com
6 years, 8 months ago (2014-04-25 21:48:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhaoqin@google.com/251683005/1
6 years, 8 months ago (2014-04-25 22:29:39 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-26 02:19:51 UTC) #6
Message was sent while issue was closed.
Change committed as 266321

Powered by Google App Engine
This is Rietveld 408576698