Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 251683003: Fix CurrentMapForDeprecated() to return MaybeHandle instead of a null handle. (Closed)

Created:
6 years, 8 months ago by Benedikt Meurer
Modified:
6 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
git@github.com:v8/v8.git@master
Visibility:
Public.

Description

Fix CurrentMapForDeprecated() to return MaybeHandle instead of a null handle. Also fix TryMigrateInstance() to return bool instead of the parameter or a null handle. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20996

Patch Set 1 #

Total comments: 2

Patch Set 2 : Mark functions that return MaybeHandle with V8_WARN_UNUSED_RESULT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -25 lines) Patch
M src/ast.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/objects.h View 1 2 chunks +6 lines, -4 lines 0 comments Download
M src/objects.cc View 1 3 chunks +17 lines, -12 lines 0 comments Download
M src/runtime.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/type-info.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
PTAL
6 years, 8 months ago (2014-04-25 11:06:05 UTC) #1
Yang
LGTM with comment. https://codereview.chromium.org/251683003/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/251683003/diff/1/src/objects.h#newcode6461 src/objects.h:6461: static MaybeHandle<Map> CurrentMapForDeprecated(Handle<Map> map); We generally ...
6 years, 8 months ago (2014-04-25 11:48:06 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/251683003/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/251683003/diff/1/src/objects.h#newcode6461 src/objects.h:6461: static MaybeHandle<Map> CurrentMapForDeprecated(Handle<Map> map); On 2014/04/25 11:48:06, Yang wrote: ...
6 years, 8 months ago (2014-04-26 10:12:42 UTC) #3
Benedikt Meurer
6 years, 7 months ago (2014-04-28 05:47:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20996 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698