Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 2516793002: Use the bounding box of all descendants for localVisualRect if there is a mask. (Closed)
Patch Set: none Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/PaintLayer.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.cpp b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
index 552fcb53bae7c62861a5ba181e2a454e0944a562..e1996a4c26dd98496167a80bbab5e6e8f2430eb8 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayer.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
@@ -2339,7 +2339,7 @@ PaintLayer* PaintLayer::hitTestChildren(
return resultLayer;
}
-FloatRect PaintLayer::boxForFilter() const {
+FloatRect PaintLayer::boxForFilterOrMask() const {
return FloatRect(physicalBoundingBoxIncludingStackingChildren(
LayoutPoint(), PaintLayer::CalculateBoundsOptions::
IncludeTransformsAndCompositedChildLayers));
@@ -3022,7 +3022,7 @@ PaintLayer::createCompositorFilterOperationsForFilter(
const ComputedStyle& style) {
FloatRect zoomedReferenceBox;
if (style.filter().hasReferenceFilter())
- zoomedReferenceBox = boxForFilter();
+ zoomedReferenceBox = boxForFilterOrMask();
FilterEffectBuilder builder(enclosingNode(), zoomedReferenceBox,
style.effectiveZoom());
return builder.buildFilterOperations(addReflectionToFilterOperations(style));
@@ -3033,7 +3033,7 @@ PaintLayer::createCompositorFilterOperationsForBackdropFilter(
const ComputedStyle& style) {
FloatRect zoomedReferenceBox;
if (style.backdropFilter().hasReferenceFilter())
- zoomedReferenceBox = boxForFilter();
+ zoomedReferenceBox = boxForFilterOrMask();
FilterEffectBuilder builder(enclosingNode(), zoomedReferenceBox,
style.effectiveZoom());
return builder.buildFilterOperations(style.backdropFilter());
@@ -3081,7 +3081,7 @@ FilterEffect* PaintLayer::lastFilterEffect() const {
const ComputedStyle& style = layoutObject()->styleRef();
FloatRect zoomedReferenceBox;
if (style.filter().hasReferenceFilter())
- zoomedReferenceBox = boxForFilter();
+ zoomedReferenceBox = boxForFilterOrMask();
FilterEffectBuilder builder(enclosingNode(), zoomedReferenceBox,
style.effectiveZoom());
resourceInfo->setLastEffect(
« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698