Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 251673002: Get rid of PageSet.FromDict in perf/benchmark/maps (Closed)

Created:
6 years, 8 months ago by nednguyen
Modified:
6 years, 7 months ago
Reviewers:
tonyg, dtu, nduca
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Get rid of PageSet.FromDict in perf's maps benchmark. BUG=239179 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266773

Patch Set 1 #

Patch Set 2 : Lint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -16 lines) Patch
M tools/perf/benchmarks/maps.py View 1 3 chunks +22 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
nednguyen
6 years, 7 months ago (2014-04-28 21:00:29 UTC) #1
dtu
lgtm
6 years, 7 months ago (2014-04-28 21:39:27 UTC) #2
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 7 months ago (2014-04-28 21:39:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/251673002/1
6 years, 7 months ago (2014-04-28 21:40:39 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 22:27:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-28 22:27:09 UTC) #6
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 7 months ago (2014-04-28 22:31:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/251673002/20001
6 years, 7 months ago (2014-04-28 22:33:01 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 07:40:46 UTC) #9
Message was sent while issue was closed.
Change committed as 266773

Powered by Google App Engine
This is Rietveld 408576698