Remove /arch:AVX and /arch:AVX2 from libvpx

third_party/libvpx/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/arm.gni")
 import("//build/config/android/config.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//third_party/libvpx/libvpx_srcs.gni")
 import("//third_party/yasm/yasm_assemble.gni")
 
@@ skipping 20 matching lines @@
 
 if (is_nacl) {
   platform_include_dir = "//third_party/libvpx/source/config/nacl"
 } else {
   # The mac configurations are currently a relic. They were useful when
   # x86inc.asm did not work for MACH_O but now the build is identical to the
   # linux config. iOS for arm on the other hand needs an apple-specific twist in
   # vpx_config.asm
   if (is_ios && current_cpu == "arm") {
     os_category = current_os
-  } else if (is_posix) { # Should cover linux, mac, and the ios simulator.
+  } else if (is_posix) {  # Should cover linux, mac, and the ios simulator.
     os_category = "linux"
-  } else { # This should only match windows.
+  } else {  # This should only match windows.
     os_category = current_os
   }
   platform_include_dir =
       "//third_party/libvpx/source/config/$os_category/$cpu_arch_full"
 }
 
 config("libvpx_config") {
   include_dirs = [
     "//third_party/libvpx/source/config",
     platform_include_dir,
@@ skipping 119 matching lines @@
       sources = libvpx_srcs_x86_64_sse4_1
     }
   }
 
   source_set("libvpx_intrinsics_avx") {
     configs += [ ":libvpx_config" ]
     configs -= [ "//build/config/compiler:chromium_code" ]
     configs += [ "//build/config/compiler:no_chromium_code" ]
     configs += [ ":libvpx_warnings" ]
     if (is_win) {
-      cflags = [ "/arch:AVX" ]
+      if (is_clang) {
+        cflags = [ "/arch:AVX" ]
+      } else {
+        # /arch:AVX leads to ODR violations in CRT functions that are inline but
+        # not inlined. crbug.com/666707
+        cflags = [ "/wd4752" ]
+      }
     } else {
       cflags = [ "-mavx" ]
     }
     if (current_cpu == "x86") {
       sources = libvpx_srcs_x86_avx
     } else if (current_cpu == "x64") {
       sources = libvpx_srcs_x86_64_avx
     }
   }
 
   source_set("libvpx_intrinsics_avx2") {
     configs += [ ":libvpx_config" ]
     configs -= [ "//build/config/compiler:chromium_code" ]
     configs += [ "//build/config/compiler:no_chromium_code" ]
     configs += [ ":libvpx_warnings" ]
     if (is_win) {
-      cflags = [ "/arch:AVX2" ]
+      if (is_clang) {
+        cflags = [ "/arch:AVX2" ]
+      } else {
+        # /arch:AVX leads to ODR violations in CRT functions that are inline but
+        # not inlined. crbug.com/666707
+        cflags = [ "/wd4752" ]
+      }
     } else {
       cflags = [ "-mavx2" ]
     }
     if (current_cpu == "x86") {
       sources = libvpx_srcs_x86_avx2
     } else if (current_cpu == "x64") {
       sources = libvpx_srcs_x86_64_avx2
     }
   }
 }
@@ skipping 116 matching lines @@
   }
   if (is_android) {
     deps += [ "//third_party/android_tools:cpu_features" ]
   }
   if (current_cpu == "arm" && arm_assembly_sources != []) {
     deps += [ ":libvpx_assembly_arm" ]
   }
 
   public_configs = [ ":libvpx_external_config" ]
 }