Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 2516673002: [ObjC ARC] Converts ios/testing:ocmock_support to ARC.Automatically generated ARCMigrate commitN… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/testing:ocmock_support to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/02f955b4e2549239be02c262fba8f241664f399b Cr-Commit-Position: refs/heads/master@{#433537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M ios/testing/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/testing/ocmock_complex_type_helper.mm View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
stkhapugin
PTAL. Passes downstream tests.
4 years, 1 month ago (2016-11-21 10:55:33 UTC) #6
noyau (Ping after 24h)
lgtm
4 years, 1 month ago (2016-11-21 11:56:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516673002/1
4 years, 1 month ago (2016-11-21 12:21:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 14:33:37 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 14:35:50 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02f955b4e2549239be02c262fba8f241664f399b
Cr-Commit-Position: refs/heads/master@{#433537}

Powered by Google App Engine
This is Rietveld 408576698