Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1179)

Issue 2516663002: [ObjC ARC] Converts ios/chrome/browser/ui/voice:unit_tests to ARC.Automatically generated ARCMigr… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/voice:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/520469a7da6ed46c94557ca30fb06ff7e66c79c1 Cr-Commit-Position: refs/heads/master@{#436295}

Patch Set 1 #

Patch Set 2 : removed scoped nsobjects #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -20 lines) Patch
M ios/chrome/browser/ui/voice/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/voice/text_to_speech_player_unittest.mm View 1 7 chunks +16 lines, -20 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
stkhapugin
PTAL
4 years ago (2016-11-24 15:40:05 UTC) #8
noyau (Ping after 24h)
lgtm
4 years ago (2016-11-24 15:59:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516663002/20001
4 years ago (2016-12-05 13:30:26 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-05 15:27:26 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-05 15:30:55 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/520469a7da6ed46c94557ca30fb06ff7e66c79c1
Cr-Commit-Position: refs/heads/master@{#436295}

Powered by Google App Engine
This is Rietveld 408576698