Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 2516653002: [ObjC ARC] Converts ios/chrome/browser/net:net to ARC.Automatically generated ARCMigrate commitN… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years ago
Reviewers:
sdefresne
CC:
chromium-reviews, cbentzel+watch_chromium.org, pkl (ping after 24h if needed), mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/net:net to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/0da6f15bd0cfdb1847ee5d38cf48e4579ed745b2 Cr-Commit-Position: refs/heads/master@{#434369}

Patch Set 1 #

Patch Set 2 : s/BindBlock/BindBlockArc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -11 lines) Patch
M ios/chrome/browser/net/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/net/chrome_cookie_store_ios_client.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/net/connection_type_observer_bridge.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/net/cookie_util.mm View 1 2 chunks +5 lines, -1 line 0 comments Download
M ios/chrome/browser/net/image_fetcher.mm View 3 chunks +5 lines, -2 lines 0 comments Download
M ios/chrome/browser/net/ios_chrome_http_user_agent_settings.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/net/metrics_network_client.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/net/metrics_network_client_manager.mm View 1 3 chunks +12 lines, -8 lines 0 comments Download
M ios/chrome/browser/net/retryable_url_fetcher.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
stkhapugin
Passes downstream bots
4 years ago (2016-11-24 09:38:35 UTC) #6
sdefresne
lgtm
4 years ago (2016-11-24 14:00:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516653002/1
4 years ago (2016-11-24 14:09:18 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/113032)
4 years ago (2016-11-24 14:19:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516653002/20001
4 years ago (2016-11-24 17:18:08 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-24 18:47:10 UTC) #16
commit-bot: I haz the power
4 years ago (2016-11-24 18:50:24 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0da6f15bd0cfdb1847ee5d38cf48e4579ed745b2
Cr-Commit-Position: refs/heads/master@{#434369}

Powered by Google App Engine
This is Rietveld 408576698