Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2516643002:
[ObjC ARC] Converts ios/chrome/browser/itunes_links:itunes_links to ARC. (Closed)
|
Created:
4 years, 1 month ago by stkhapugin Modified:
4 years ago CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, sdefresne+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[ObjC ARC] Converts ios/chrome/browser/itunes_links:itunes_links to ARC.
Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
Committed: https://crrev.com/a3e5f7dbadf9378884651af992fec7f770f01984
Cr-Commit-Position: refs/heads/master@{#436305}
Patch Set 1 #Patch Set 2 : removed weak nsobject #
Messages
Total messages: 28 (17 generated)
The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
stkhapugin@chromium.org changed reviewers: + jif@google.com
PTAL. passes downstream tests
jif@chromium.org changed reviewers: + jif@chromium.org
lgtm
Description was changed from ========== [ObjC ARC] Converts ios/chrome/browser/itunes_links:itunes_links to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None ========== to ========== [ObjC ARC] Converts ios/chrome/browser/itunes_links:itunes_links to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None ==========
The CQ bit was checked by stkhapugin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by stkhapugin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
stkhapugin@chromium.org changed reviewers: + sdefresne@chromium.org - jif@google.com
Sylvain, PTAL as OWNER. Presubmit complaints about owners, while the code review tool is telling me that jif owns all the code in question.
rs lgtm
The CQ bit was checked by stkhapugin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jif@chromium.org, sdefresne@chromium.org Link to the patchset: https://codereview.chromium.org/2516643002/#ps20001 (title: "removed weak nsobject")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480945729873220,
"parent_rev": "b3509d44ea042b8f069548697cee168dcc03cc51", "commit_rev":
"e096c45bb5919ffffe80f8fb4b2f944ef6151e18"}
Message was sent while issue was closed.
Description was changed from ========== [ObjC ARC] Converts ios/chrome/browser/itunes_links:itunes_links to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None ========== to ========== [ObjC ARC] Converts ios/chrome/browser/itunes_links:itunes_links to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [ObjC ARC] Converts ios/chrome/browser/itunes_links:itunes_links to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None ========== to ========== [ObjC ARC] Converts ios/chrome/browser/itunes_links:itunes_links to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/a3e5f7dbadf9378884651af992fec7f770f01984 Cr-Commit-Position: refs/heads/master@{#436305} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a3e5f7dbadf9378884651af992fec7f770f01984 Cr-Commit-Position: refs/heads/master@{#436305} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
