Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 251663003: Reuse the locked version to reduce the code duplication. (Closed)

Created:
6 years, 8 months ago by ycheo (away)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Reuse the locked version to reduce the code duplication. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266509

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwSettings.java View 22 chunks +22 lines, -22 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ycheo (away)
6 years, 8 months ago (2014-04-25 08:30:29 UTC) #1
mnaganov (inactive)
lgtm
6 years, 8 months ago (2014-04-25 08:55:42 UTC) #2
ycheo (away)
The CQ bit was checked by ycheo@chromium.org
6 years, 8 months ago (2014-04-28 01:53:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ycheo@chromium.org/251663003/1
6 years, 8 months ago (2014-04-28 01:54:37 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-28 02:02:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_gn_rel
6 years, 8 months ago (2014-04-28 02:03:00 UTC) #6
ycheo (away)
The CQ bit was checked by ycheo@chromium.org
6 years, 8 months ago (2014-04-28 05:02:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ycheo@chromium.org/251663003/1
6 years, 8 months ago (2014-04-28 05:03:31 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 11:53:46 UTC) #9
Message was sent while issue was closed.
Change committed as 266509

Powered by Google App Engine
This is Rietveld 408576698