Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2516613002:
Profile deletion: prevent profile creation race in dying browser. (Closed)
DescriptionProfile deletion: prevent profile creation race in dying browser.
When sole profile deleted, browser can become windowless and be closed.
In the same time expected a new profile to be created and opened in new
window.
If profile creation will lose the race - browser will be closed, and
probably profile deletion will not happened, otherwise browser will be
switched on new profile as expected.
BUG=
R=anthonyvd@chromium.org, bauerb@chromium.org
Committed: https://crrev.com/1e6671aafd8e7d7a10c34cf82164b264179c4b0a
Cr-Commit-Position: refs/heads/master@{#434464}
Patch Set 1 #
Total comments: 5
Patch Set 2 : Review fixes #
Messages
Total messages: 37 (17 generated)
Mostly nits, and some additional cleanup that could potentially be done in a followup CL: https://codereview.chromium.org/2516613002/diff/1/chrome/browser/ui/webui/pro... File chrome/browser/ui/webui/profile_helper.cc (right): https://codereview.chromium.org/2516613002/diff/1/chrome/browser/ui/webui/pro... chrome/browser/ui/webui/profile_helper.cc:23: namespace { Can you add an empty line after this one? https://codereview.chromium.org/2516613002/diff/1/chrome/browser/ui/webui/pro... chrome/browser/ui/webui/profile_helper.cc:30: } // namespace And after this one? https://codereview.chromium.org/2516613002/diff/1/chrome/browser/ui/webui/pro... chrome/browser/ui/webui/profile_helper.cc:31: void OpenNewWindowForProfile(const std::unique_ptr<ScopedKeepAlive>& keep_alive, Both the ScopedKeepAlive and the CreateStatus are only used when this method is called internally; external callers only care about the aspect of opening a new window. Could we use a callback in an anonymous namespace for DeleteProfileAtPath() below that takes the ScopedAlive and the CreateStatus, and have the method declared in the header only take the profile? https://codereview.chromium.org/2516613002/diff/1/chrome/browser/ui/webui/pro... chrome/browser/ui/webui/profile_helper.cc:58: DCHECK(web_ui); This parameter seems unnecessary... https://codereview.chromium.org/2516613002/diff/1/chrome/browser/ui/webui/pro... File chrome/browser/ui/webui/profile_helper.h (right): https://codereview.chromium.org/2516613002/diff/1/chrome/browser/ui/webui/pro... chrome/browser/ui/webui/profile_helper.h:19: void OpenNewWindowForProfile(const std::unique_ptr<ScopedKeepAlive>& keep_alive, Pass the unique_ptr without the const reference.
lgtm % bauerb@'s comment about the parameters to OpenNewWindowForProfile.
On 2016/11/18 14:42:11, anthonyvd wrote: > lgtm % bauerb@'s comment about the parameters to OpenNewWindowForProfile. done.
lgtm
The CQ bit was checked by palar@yandex-team.ru
The patchset sent to the CQ was uploaded after l-g-t-m from anthonyvd@chromium.org Link to the patchset: https://codereview.chromium.org/2516613002/#ps20001 (title: "Review fixes")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Profile deletion: prevent profile creation race in dying browser. When sole profile deleted, browser can become windowless and be closed. In the same time expected a new profile to be created and opened in new window. If profile creation will lose the race - browser will be closed, and probably profile deletion will not happened, otherwise browser will be switched on new profile as expected. BUG= R=anthonyvd@chromium.org, bauerb@chromium.org ========== to ========== Profile deletion: prevent profile creation race in dying browser. When sole profile deleted, browser can become windowless and be closed. In the same time expected a new profile to be created and opened in new window. If profile creation will lose the race - browser will be closed, and probably profile deletion will not happened, otherwise browser will be switched on new profile as expected. BUG= R=anthonyvd@chromium.org, bauerb@chromium.org ==========
palar@yandex-team.ru changed reviewers: + jochen@chromium.org, stevenjb@chromium.org
On 2016/11/21 10:01:15, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) Added reviewers.
chrome/browser/lifetime lgtm
palar@yandex-team.ru changed reviewers: + dbeam@chromium.org
On 2016/11/21 11:12:02, jochen wrote: > chrome/browser/lifetime lgtm Add more reviewers for chrome/browser/ui/webui/options/create_profile_handler.cc
chrome/browser/ui/webui/options lgtm
The CQ bit was checked by palar@yandex-team.ru
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was unchecked by palar@yandex-team.ru
The CQ bit was checked by palar@yandex-team.ru
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by palar@yandex-team.ru
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by palar@yandex-team.ru
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480062735579640,
"parent_rev": "a1756ed9132654bcc63de533e35b291a7f739bb3", "commit_rev":
"49da3a1c83b09065bc7256468b648d9838ded2ae"}
Message was sent while issue was closed.
Description was changed from ========== Profile deletion: prevent profile creation race in dying browser. When sole profile deleted, browser can become windowless and be closed. In the same time expected a new profile to be created and opened in new window. If profile creation will lose the race - browser will be closed, and probably profile deletion will not happened, otherwise browser will be switched on new profile as expected. BUG= R=anthonyvd@chromium.org, bauerb@chromium.org ========== to ========== Profile deletion: prevent profile creation race in dying browser. When sole profile deleted, browser can become windowless and be closed. In the same time expected a new profile to be created and opened in new window. If profile creation will lose the race - browser will be closed, and probably profile deletion will not happened, otherwise browser will be switched on new profile as expected. BUG= R=anthonyvd@chromium.org, bauerb@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Profile deletion: prevent profile creation race in dying browser. When sole profile deleted, browser can become windowless and be closed. In the same time expected a new profile to be created and opened in new window. If profile creation will lose the race - browser will be closed, and probably profile deletion will not happened, otherwise browser will be switched on new profile as expected. BUG= R=anthonyvd@chromium.org, bauerb@chromium.org ========== to ========== Profile deletion: prevent profile creation race in dying browser. When sole profile deleted, browser can become windowless and be closed. In the same time expected a new profile to be created and opened in new window. If profile creation will lose the race - browser will be closed, and probably profile deletion will not happened, otherwise browser will be switched on new profile as expected. BUG= R=anthonyvd@chromium.org, bauerb@chromium.org Committed: https://crrev.com/1e6671aafd8e7d7a10c34cf82164b264179c4b0a Cr-Commit-Position: refs/heads/master@{#434464} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1e6671aafd8e7d7a10c34cf82164b264179c4b0a Cr-Commit-Position: refs/heads/master@{#434464} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
