Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 2516603003: Add CHECK to EnumerateDevices call in PepperDeviceManager (Closed)

Created:
4 years, 1 month ago by Guido Urdaneta
Modified:
4 years, 1 month ago
Reviewers:
bbudge
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CHECK to EnumerateDevices call in PepperDeviceManager BUG=666715 Committed: https://crrev.com/48c91fbefe2cbe48472d91c265da3283bd3870b8 Cr-Commit-Position: refs/heads/master@{#433417}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/renderer/pepper/pepper_media_device_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Guido Urdaneta
Hi, PTAL. There is a crash being reported where EnumerateDevices is being called specifying false ...
4 years, 1 month ago (2016-11-18 15:01:25 UTC) #2
bbudge
lgtm
4 years, 1 month ago (2016-11-18 15:12:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516603003/1
4 years, 1 month ago (2016-11-18 15:24:08 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/275659)
4 years, 1 month ago (2016-11-18 19:20:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516603003/1
4 years, 1 month ago (2016-11-19 10:24:25 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-19 10:40:25 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 10:43:07 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48c91fbefe2cbe48472d91c265da3283bd3870b8
Cr-Commit-Position: refs/heads/master@{#433417}

Powered by Google App Engine
This is Rietveld 408576698