Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 2516603002: [crankshaft] Don't inline the fast path for instanceof if the function has a non-instance .prototype (Closed)

Created:
4 years, 1 month ago by Toon Verwaest
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Don't inline the fast path for instanceof if the function has a non-instance .prototype BUG=chromium:666308 Committed: https://crrev.com/0c70f3729e751bb3149f5b82d9e42db00c3cec3d Cr-Commit-Position: refs/heads/master@{#41105}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M src/crankshaft/hydrogen.cc View 1 chunk +3 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-666308.js View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Toon Verwaest
ptal
4 years, 1 month ago (2016-11-18 11:02:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516603002/1
4 years, 1 month ago (2016-11-18 11:02:43 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-18 11:02:44 UTC) #6
Igor Sheludko
lgtm
4 years, 1 month ago (2016-11-18 11:05:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516603002/1
4 years, 1 month ago (2016-11-18 12:45:18 UTC) #13
Benedikt Meurer
LGTM.
4 years, 1 month ago (2016-11-18 12:48:51 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 12:57:10 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 12:57:48 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c70f3729e751bb3149f5b82d9e42db00c3cec3d
Cr-Commit-Position: refs/heads/master@{#41105}

Powered by Google App Engine
This is Rietveld 408576698