Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 25166002: Fix build on Fedora 20. (Closed)

Created:
7 years, 2 months ago by pwnall-personal
Modified:
7 years, 2 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, jam, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix build on Fedora 20. The build broke because atk_focus_tracker_notify is deprecated since ATK 2.9.4 and Chromium builds with warnings set as errors. BUG=298815 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225895

Patch Set 1 #

Patch Set 2 : Better guard. #

Patch Set 3 : Feedback from dmazzoni. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_gtk.cc View 1 2 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pwnall-personal
I tried to build Chromium on Fedora 20 (alpha), and ran into this issue. After ...
7 years, 2 months ago (2013-09-28 23:30:53 UTC) #1
dmazzoni
Thanks! Rather than the ifdef, please just remove it entirely. I read up on the ...
7 years, 2 months ago (2013-09-29 06:55:26 UTC) #2
pwnall-personal
On 2013/09/29 06:55:26, Dominic Mazzoni wrote: > Thanks! > > Rather than the ifdef, please ...
7 years, 2 months ago (2013-09-29 07:18:15 UTC) #3
dmazzoni
On 2013/09/29 07:18:15, pwnall wrote: > On 2013/09/29 06:55:26, Dominic Mazzoni wrote: > > Thanks! ...
7 years, 2 months ago (2013-09-29 07:28:26 UTC) #4
pwnall-personal
On 2013/09/29 07:28:26, Dominic Mazzoni wrote: > On 2013/09/29 07:18:15, pwnall wrote: > > On ...
7 years, 2 months ago (2013-09-29 07:44:14 UTC) #5
dmazzoni
lgtm Thanks for updating the comment. Emitting the event seems to work in practice even ...
7 years, 2 months ago (2013-09-29 07:53:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/costan@gmail.com/25166002/9001
7 years, 2 months ago (2013-09-29 07:54:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/costan@gmail.com/25166002/9001
7 years, 2 months ago (2013-09-29 12:04:33 UTC) #8
commit-bot: I haz the power
7 years, 2 months ago (2013-09-29 15:39:26 UTC) #9
Message was sent while issue was closed.
Change committed as 225895

Powered by Google App Engine
This is Rietveld 408576698