Introduces DevToolsManagerDelegate.

content/browser/service_worker/service_worker_context_wrapper.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_CONTEXT_WRAPPER_H_
 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_CONTEXT_WRAPPER_H_
 
 #include "base/files/file_path.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "content/browser/service_worker/service_worker_context_core.h"
+#include "content/browser/service_worker/service_worker_context_observer.h"
 #include "content/common/content_export.h"
 #include "content/public/browser/service_worker_context.h"
 
 namespace base {
 class FilePath;
 }
 
 namespace quota {
 class QuotaManagerProxy;
 }
@@ skipping 26 matching lines @@
                                      const GURL& script_url,
                                      int source_process_id,
                                      const ResultCallback& continuation)
       OVERRIDE;
 
   virtual void UnregisterServiceWorker(const GURL& pattern,
                                        int source_process_id,
                                        const ResultCallback& continuation)
       OVERRIDE;
 
+  virtual scoped_ptr<base::CallbackList<void(void)>::Subscription>

[michaeln, 2014/04/25 22:09:14]

From callback_list.h

  // Add a callback to the list. The callback will remain registered until the
  // returned Subscription is destroyed, which must occur before the
  // CallbackList is destroyed.
  scoped_ptr<Subscription> Add(const CallbackType& cb) WARN_UNUSED_RESULT;

The part about guaranteeing that all Subscriptions are destroyed prior to the
list being destroyed seems problematic for this use case.

[horo, 2014/04/26 08:00:45]

Done.
Oh, I didn't understand that. Thank you.

+      RegisterStatusChangeCallback(
+          const base::Callback<void(void)>& callback) OVERRIDE;
+
+  virtual void GetRunningServiceWorkerInfo(
+      const GetRunningServiceWorkerInfoCallback& callback) OVERRIDE;
+
   void AddObserver(ServiceWorkerContextObserver* observer);
   void RemoveObserver(ServiceWorkerContextObserver* observer);
 
  private:
   friend class base::RefCountedThreadSafe<ServiceWorkerContextWrapper>;
   virtual ~ServiceWorkerContextWrapper();
 
+  class CallbackProxy : public ServiceWorkerContextObserver,

[michaeln, 2014/04/25 22:09:14]

Alternatively, it looks like ServiceWorkerContextWrapper could derive from
ServiceWorkerContextObserver directly, fewer moving parts.

[horo, 2014/04/26 08:00:45]

Done.

+                        public base::RefCountedThreadSafe<CallbackProxy> {
+   public:
+    CallbackProxy() {}
+    virtual ~CallbackProxy() {}
+    scoped_ptr<base::CallbackList<void(void)>::Subscription> Add(
+        const base::Callback<void(void)>& callback);
+    virtual void OnWorkerStarted(int64 version_id,
+                                 int process_id,
+                                 int thread_id);
+    virtual void OnWorkerStopped(int64 version_id,
+                                 int process_id,
+                                 int thread_id);
+    virtual void OnVersionStateChanged(int64 version_id);
+
+   private:
+    void onStatusChanged();
+    base::CallbackList<void(void)> status_change_callback_list_;
+  };
+
+  void onStatusChanged();

[michaeln, 2014/04/25 22:09:14]

is this used?

+
   scoped_ptr<ServiceWorkerContextCore> context_core_;
   scoped_refptr<ObserverListThreadSafe<ServiceWorkerContextObserver> >
       observer_list_;
+  scoped_refptr<CallbackProxy> callback_proxy_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_CONTEXT_WRAPPER_H_