content/browser/devtools/devtools_agent_host_impl.h - Issue 251653003: Introduces DevToolsManagerDelegate.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/devtools/devtools_agent_host_impl.h

Issue 251653003: Introduces DevToolsManagerDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove forward declaration of DevToolsAgentHost in chrome_devtools_manager_delegate.h Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_AGENT_HOST_IMPL_H_	5 #ifndef CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_AGENT_HOST_IMPL_H_

6 #define CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_AGENT_HOST_IMPL_H_	6 #define CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_AGENT_HOST_IMPL_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 #include "base/compiler_specific.h"	10 #include "base/compiler_specific.h"

(...skipping 35 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
46 virtual void InspectElement(int x, int y) OVERRIDE;	46 virtual void InspectElement(int x, int y) OVERRIDE;

47	47

48 virtual std::string GetId() OVERRIDE;	48 virtual std::string GetId() OVERRIDE;

49	49

50 virtual RenderViewHost* GetRenderViewHost() OVERRIDE;	50 virtual RenderViewHost* GetRenderViewHost() OVERRIDE;

51	51

52 virtual void DisconnectRenderViewHost() OVERRIDE;	52 virtual void DisconnectRenderViewHost() OVERRIDE;

53	53

54 virtual void ConnectRenderViewHost(RenderViewHost* rvh) OVERRIDE;	54 virtual void ConnectRenderViewHost(RenderViewHost* rvh) OVERRIDE;

55	55

	56 virtual bool IsWorker() OVERRIDE;
	kinuko 2014/05/13 03:48:56 nit: could probably be a const method? nit: could probably be a const method? horo 2014/05/13 03:55:37 Done. Show quoted text On 2014/05/13 03:48:56, kinuko wrote: > nit: could probably be a const method? Done.
	57

56 protected:	58 protected:

57 DevToolsAgentHostImpl();	59 DevToolsAgentHostImpl();

58 virtual ~DevToolsAgentHostImpl();	60 virtual ~DevToolsAgentHostImpl();

59	61

60 void NotifyCloseListener();	62 void NotifyCloseListener();

61	63

62 private:	64 private:

63 CloseListener* close_listener_;	65 CloseListener* close_listener_;

64 const std::string id_;	66 const std::string id_;

65 };	67 };

66	68

67 } // namespace content	69 } // namespace content

68	70

69 #endif // CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_AGENT_HOST_IMPL_H_	71 #endif // CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_AGENT_HOST_IMPL_H_

OLD	NEW

« no previous file with comments | « chrome/chrome_debugger.gypi ('k') | content/browser/devtools/devtools_agent_host_impl.cc » ('j') | no next file with comments »