Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Side by Side Diff: content/public/browser/devtools_manager.h

Issue 251653003: Introduces DevToolsManagerDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Register OpenDevToolsWindowForWorkerCallback to DevToolsManager Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/devtools/devtools_manager_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_H_
6 #define CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_H_ 6 #define CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "content/common/content_export.h" 11 #include "content/common/content_export.h"
12 12
13 namespace IPC { 13 namespace IPC {
14 class Message; 14 class Message;
15 } 15 }
16 16
17 namespace content { 17 namespace content {
18 18
19 class BrowserContext;
19 class DevToolsAgentHost; 20 class DevToolsAgentHost;
20 class DevToolsClientHost; 21 class DevToolsClientHost;
21 22
22 // DevToolsManager connects a devtools client to inspected agent and routes 23 // DevToolsManager connects a devtools client to inspected agent and routes
23 // devtools messages between the inspected instance represented by the agent 24 // devtools messages between the inspected instance represented by the agent
24 // and devtools front-end represented by the client. If inspected agent 25 // and devtools front-end represented by the client. If inspected agent
25 // gets terminated DevToolsManager will notify corresponding client and 26 // gets terminated DevToolsManager will notify corresponding client and
26 // remove it from the map. 27 // remove it from the map.
27 class CONTENT_EXPORT DevToolsManager { 28 class CONTENT_EXPORT DevToolsManager {
28 public: 29 public:
(...skipping 22 matching lines...) Expand all
51 52
52 // This method will remove all references from the manager to the 53 // This method will remove all references from the manager to the
53 // DevToolsClientHost and unregister all listeners related to the 54 // DevToolsClientHost and unregister all listeners related to the
54 // DevToolsClientHost. Called by closing client. 55 // DevToolsClientHost. Called by closing client.
55 virtual void ClientHostClosing(DevToolsClientHost* client_host) = 0; 56 virtual void ClientHostClosing(DevToolsClientHost* client_host) = 0;
56 57
57 typedef base::Callback<void(DevToolsAgentHost*, bool attached)> Callback; 58 typedef base::Callback<void(DevToolsAgentHost*, bool attached)> Callback;
58 59
59 virtual void AddAgentStateCallback(const Callback& callback) = 0; 60 virtual void AddAgentStateCallback(const Callback& callback) = 0;
60 virtual void RemoveAgentStateCallback(const Callback& callback) = 0; 61 virtual void RemoveAgentStateCallback(const Callback& callback) = 0;
62
63 typedef base::Callback<void(BrowserContext*, DevToolsAgentHost*)>
64 WindowOpenCallback;
65
66 virtual void RegisterOpenDevToolsWindowForWorkerCallback(
pfeldman 2014/05/07 16:01:30 It does not look too pretty. John, do you think we
jam 2014/05/08 16:27:17 just to make sure I understand, do you mean conten
67 const WindowOpenCallback& window_open_callback) = 0;
61 }; 68 };
62 69
63 } // namespace content 70 } // namespace content
64 71
65 #endif // CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_H_ 72 #endif // CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_H_
OLDNEW
« no previous file with comments | « content/browser/devtools/devtools_manager_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698