Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: chrome/browser/resources/print_preview/data/print_ticket_store.js

Issue 2516523002: Fix CrOS reverting to Save as PDF and random PDF preview fail (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/data/print_ticket_store.js
diff --git a/chrome/browser/resources/print_preview/data/print_ticket_store.js b/chrome/browser/resources/print_preview/data/print_ticket_store.js
index c3abdf2812f4f8315914de61bca3041b30148650..29c05f21c2fa025a40670f56124cfe689da2073d 100644
--- a/chrome/browser/resources/print_preview/data/print_ticket_store.js
+++ b/chrome/browser/resources/print_preview/data/print_ticket_store.js
@@ -558,6 +558,8 @@ cr.define('print_preview', function() {
* @private
*/
onSelectedDestinationCapabilitiesReady_: function() {
+ if (!this.destinationStore_.selectedDestination)
dpapad 2016/11/18 00:29:16 Can you add a comment explaining how this function
rbpotter 2016/11/18 02:59:23 I was getting an error here previously but after f
+ return;
var caps = assert(
this.destinationStore_.selectedDestination.capabilities);
var isFirstUpdate = this.capabilitiesHolder_.get() == null;

Powered by Google App Engine
This is Rietveld 408576698