Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2516513002: Lazily create PPDCache directory on first store. (Closed)

Created:
4 years, 1 month ago by Carlson
Modified:
4 years, 1 month ago
Reviewers:
stevenjb, justincarlson
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Lazily create PPDCache directory on first store. BUG=666532 Committed: https://crrev.com/b7550fad8f766c01c60ac03c6e82a6d2ae587e6b Cr-Commit-Position: refs/heads/master@{#433268}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chromeos/printing/ppd_cache.h View 1 chunk +3 lines, -1 line 0 comments Download
M chromeos/printing/ppd_cache.cc View 3 chunks +20 lines, -0 lines 0 comments Download
M chromeos/printing/ppd_cache_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Carlson
4 years, 1 month ago (2016-11-17 23:54:12 UTC) #2
stevenjb
lgtm
4 years, 1 month ago (2016-11-18 17:39:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516513002/1
4 years, 1 month ago (2016-11-18 18:11:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 19:38:26 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 19:40:20 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b7550fad8f766c01c60ac03c6e82a6d2ae587e6b
Cr-Commit-Position: refs/heads/master@{#433268}

Powered by Google App Engine
This is Rietveld 408576698