requestIdleCallback: Yield for high priority work

requestIdleCallback: Yield for high priority work

When a high priority task is pending (e.g., user input) while an idle
callback is running, we should reduce the remaining idle period length
to zero to signal the idle callback to exit. This can help reduce touch
latency.

BUG=653352
Committed: https://crrev.com/c96e8e1003ed954a54110e0ec652e46ef7a962cb
Cr-Commit-Position: refs/heads/master@{#433621}

[Sami, 2016-11-17 22:55:54]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 22:56:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sami, 2016-11-17 22:57:18]

Description was changed from

==========
requestIdleCallback: Yield for high priority work

When a high priority task is pending (e.g., user input) while an idle
callback is running, we should reduce the remaining idle period length
to zero to signal the idle callback to exit. This can help reduce touch
latency.

BUG=653352
==========

to

==========
requestIdleCallback: Yield for high priority work

When a high priority task is pending (e.g., user input) while an idle
callback is running, we should reduce the remaining idle period length
to zero to signal the idle callback to exit. This can help reduce touch
latency.

BUG=653352
==========

[Sami, 2016-11-17 22:57:18]

skyostil@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[Sami, 2016-11-17 22:57:48]

PTAL. I'm not sure we have a great way to test this...Maybe a SimTest would
work.

[commit-bot: I haz the power, 2016-11-18 00:59:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 00:59:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[rmcilroy, 2016-11-18 09:13:51]

Awesome, thanks! LGTM with optional suggestion.

https://codereview.chromium.org/2516493002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/IdleDeadline.cpp (right):

https://codereview.chromium.org/2516493002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/IdleDeadline.cpp:23: }
nit - how about just setting timeRemaining to zero, and only doing the check I'd
timeRemaining != 0?

[Sami, 2016-11-21 11:24:39]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 11:24:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sami, 2016-11-21 11:27:14]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 11:27:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sami, 2016-11-21 11:27:39]

skyostil@chromium.org changed reviewers:
+ jochen@chromium.org

[Sami, 2016-11-21 11:28:03]

Thanks! Added a test. Jochen, mind stamping this please?

https://codereview.chromium.org/2516493002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/IdleDeadline.cpp (right):

https://codereview.chromium.org/2516493002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/IdleDeadline.cpp:23: }
On 2016/11/18 09:13:51, rmcilroy wrote:
> nit - how about just setting timeRemaining to zero, and only doing the check
I'd
> timeRemaining != 0?

Good idea, done.

[jochen (gone - plz use gerrit), 2016-11-21 12:03:11]

lgtm

[Sami, 2016-11-21 13:22:53]

The CQ bit was unchecked by skyostil@chromium.org

[Sami, 2016-11-21 13:22:59]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2016-11-21 13:23:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2516493002/#ps20001
(title: "Added a test")

[commit-bot: I haz the power, 2016-11-21 13:23:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 15:28:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 15:28:42]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sami, 2016-11-21 15:28:56]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2016-11-21 15:29:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 19:33:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 19:33:36]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sami, 2016-11-21 19:34:32]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2016-11-21 19:35:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 20:13:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479756872049830,
"parent_rev": "cd9bed9495d8d3e2cd98e6dbdd4ed5ea8f5c344d", "commit_rev":
"a5ee408696746cca3a55d4bb5d1989458c9e9813"}

[commit-bot: I haz the power, 2016-11-21 20:14:15]

Description was changed from

==========
requestIdleCallback: Yield for high priority work

When a high priority task is pending (e.g., user input) while an idle
callback is running, we should reduce the remaining idle period length
to zero to signal the idle callback to exit. This can help reduce touch
latency.

BUG=653352
==========

to

==========
requestIdleCallback: Yield for high priority work

When a high priority task is pending (e.g., user input) while an idle
callback is running, we should reduce the remaining idle period length
to zero to signal the idle callback to exit. This can help reduce touch
latency.

BUG=653352
==========

[commit-bot: I haz the power, 2016-11-21 20:14:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-21 20:18:50]

Description was changed from

==========
requestIdleCallback: Yield for high priority work

When a high priority task is pending (e.g., user input) while an idle
callback is running, we should reduce the remaining idle period length
to zero to signal the idle callback to exit. This can help reduce touch
latency.

BUG=653352
==========

to

==========
requestIdleCallback: Yield for high priority work

When a high priority task is pending (e.g., user input) while an idle
callback is running, we should reduce the remaining idle period length
to zero to signal the idle callback to exit. This can help reduce touch
latency.

BUG=653352

Committed: https://crrev.com/c96e8e1003ed954a54110e0ec652e46ef7a962cb
Cr-Commit-Position: refs/heads/master@{#433621}
==========

[commit-bot: I haz the power, 2016-11-21 20:18:51]

Patchset 2 (id:??) landed as
https://crrev.com/c96e8e1003ed954a54110e0ec652e46ef7a962cb
Cr-Commit-Position: refs/heads/master@{#433621}

[esprehn, 2016-11-21 20:32:27]

esprehn@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2016-11-21 20:32:28]

https://codereview.chromium.org/2516493002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/IdleDeadline.cpp (right):

https://codereview.chromium.org/2516493002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/IdleDeadline.cpp:20: timeRemaining = 0;
Early return in blink.

if (timeRemaining < 0)
  return 0;

if (....)
  return 0;

return 1000.0 * PerformanceBase::clampTimeResolution(timeRemaining);