Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2516483002: fix #27336, ddc with recursive generic class type args (Closed)

Created:
4 years, 1 month ago by Jennifer Messerly
Modified:
4 years, 1 month ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix #27336, ddc with recursive generic class type args R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/37029a22decd161a1a962384510a0e11de85806c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -151 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 5 chunks +42 lines, -35 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 5 chunks +42 lines, -35 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 5 chunks +42 lines, -35 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 5 chunks +42 lines, -35 lines 0 comments Download
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 6 chunks +25 lines, -9 lines 0 comments Download
A pkg/dev_compiler/test/codegen/language/recursive_generic_test.dart View 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
4 years, 1 month ago (2016-11-17 22:55:52 UTC) #2
vsm
lgtm
4 years, 1 month ago (2016-11-17 23:03:27 UTC) #3
Jennifer Messerly
4 years, 1 month ago (2016-11-17 23:38:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
37029a22decd161a1a962384510a0e11de85806c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698