Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: third_party/WebKit/Source/core/dom/Document.h

Issue 2516473002: Cross-origin iframes: collect data under hypothetical loading strategies (Closed)
Patch Set: fix histograms.xml Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Document.h
diff --git a/third_party/WebKit/Source/core/dom/Document.h b/third_party/WebKit/Source/core/dom/Document.h
index 9fcc67b3ed3628decb7e00ae79a69fbba7021337..7b332413bcab0f67588118cab02e0f538d646221 100644
--- a/third_party/WebKit/Source/core/dom/Document.h
+++ b/third_party/WebKit/Source/core/dom/Document.h
@@ -232,20 +232,16 @@ enum CreateElementFlags {
// See https://crbug.com/635105.
// Logged to UMA, don't re-arrange entries without creating a new histogram.
enum WouldLoadReason {
+ Invalid,
Created,
+ WouldLoad3ScreensAway,
+ WouldLoad2ScreensAway,
+ WouldLoad1ScreenAway,
+ WouldLoadVisible,
// If outer and inner frames aren't in the same process we can't determine
// if the inner frame is visible, so just load it.
// TODO(dgrogan): Revisit after https://crbug.com/650433 is fixed.
- WouldLoadOutOfProcess,
- // The next five indicate frames that are probably used for cross-origin
- // communication.
- WouldLoadDisplayNone,
- WouldLoadZeroByZero,
- WouldLoadAboveAndLeft,
- WouldLoadAbove,
- WouldLoadLeft,
- // We have to load documents in visible frames.
- WouldLoadVisible,
+ WouldLoadNoParent,
WouldLoadReasonEnd
};
@@ -1303,8 +1299,8 @@ class CORE_EXPORT Document : public ContainerNode,
bool isInMainFrame() const;
- void maybeRecordLoadReason(WouldLoadReason);
- WouldLoadReason wouldLoadReason() { return m_wouldLoadReason; }
+ void recordDeferredLoadReason(WouldLoadReason);
+ WouldLoadReason deferredLoadReason() { return m_wouldLoadReason; }
const PropertyRegistry* propertyRegistry() const;
PropertyRegistry* propertyRegistry();
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698