Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2516473002: Cross-origin iframes: collect data under hypothetical loading strategies (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/tests/DeferredLoadingTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index b76b458d460dbedb5f04d9b9d05f17fdb7041c72..ee6248eccff9922f49cb668a24bb26566dea10cf 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -29818,6 +29818,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="Navigation.DeferredDocumentLoading.StatesV3"
enum="DocumentStateForDeferredLoadingV3">
+ <obsolete>
+ Deprecated 11/2016 in favor of Navigation.DeferredDocumentLoading.StatesV4.
dgrogan 2017/03/01 01:38:31 Also updated this.
+ </obsolete>
<owner>dgrogan@chromium.org</owner>
<summary>
Why and if cross-origin documents would be loaded if we were to defer
@@ -29827,6 +29830,19 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Navigation.DeferredDocumentLoading.StatesV4"
+ enum="DocumentStateForDeferredLoadingV4">
+ <owner>dgrogan@chromium.org</owner>
+ <summary>
+ Why and if cross-origin documents would be loaded if we were to defer
+ loading as long as possible. Changes from V3: replace detailed reasons with
+ summaries for four strategies. E.g. any document that would load under a
+ strategy of loading when a frame is two screens away is logged to the
+ WouldLoad2Screens AND WouldLoad3Screens bucket. We only record documents
+ below the current viewport, not to the right of it.
+ </summary>
+</histogram>
+
<histogram name="Navigation.EngagementTime.HTTP" units="ms">
<owner>felt@chromium.org</owner>
<summary>
@@ -85952,6 +85968,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="7" label="WouldLoadVisible"/>
</enum>
+<enum name="DocumentStateForDeferredLoadingV4" type="int">
+ <int value="0" label="Invalid"/>
+ <int value="1" label="Created"/>
+ <int value="2" label="WouldLoad3ScreensAway"/>
+ <int value="3" label="WouldLoad2ScreensAway"/>
+ <int value="4" label="WouldLoad1ScreensAway"/>
+ <int value="5" label="WouldVisible"/>
Ilya Sherman 2017/03/01 01:33:26 nit: Missing "Load" on this line?
dgrogan 2017/03/01 01:38:31 D'oh, thanks.
+ <int value="6" label="WouldLoadNoParent"/>
+</enum>
+
<enum name="DocumentWriteGatedEvaluation" type="int">
<int value="0" label="Script too long"/>
<int value="1" label="No likely external script write"/>
« no previous file with comments | « third_party/WebKit/Source/web/tests/DeferredLoadingTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698