Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2516463003: If an object's containing block is in a flow thread, so is the object. (Closed)

Created:
4 years, 1 month ago by mstensho (USE GERRIT)
Modified:
4 years, 1 month ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

If an object's containing block is in a flow thread, so is the object. Remove harmful condition in LayoutState that the object not be out-of-flow. Boring details: In simplified layout of an absolutely positioned object inside a multicol container we'd fail to realize that we were paginated, and therefore wouldn't insert pagination struts. This was only problematic for simplified layout. In normal non-simplified layout, we'd pass a non-zero page logical height to LayoutState() when entering the flow thread, and, even if the LayoutState of the absolutely positioned descendant would have no flow thread associated with it, it would still become m_paginated, thanks to the non-zero page logical height. Which was enough to get the machinery to insert struts. BUG=589004 Committed: https://crrev.com/47237f1292938078afe25cc723cf1ccfc48c92cc Cr-Commit-Position: refs/heads/master@{#433220}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/fragmentation/relayout-abspos.html View 1 chunk +27 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutState.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
4 years, 1 month ago (2016-11-18 14:23:25 UTC) #4
eae
LGTM
4 years, 1 month ago (2016-11-18 16:45:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516463003/1
4 years, 1 month ago (2016-11-18 16:47:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 17:00:18 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 17:03:36 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47237f1292938078afe25cc723cf1ccfc48c92cc
Cr-Commit-Position: refs/heads/master@{#433220}

Powered by Google App Engine
This is Rietveld 408576698