Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 2516453002: Be more selective about when we show the "Take off your headset" flow. (Closed)

Created:
4 years, 1 month ago by mthiesse
Modified:
4 years, 1 month ago
Reviewers:
bshe
CC:
chromium-reviews, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Be more selective about when we show the "Take off your headset" flow. BUG=641401 Committed: https://crrev.com/4ebc409e6f3e818512ebd0231cf9222e5d9400d3 Cr-Commit-Position: refs/heads/master@{#433214}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 1 4 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
mthiesse
PTAL
4 years, 1 month ago (2016-11-17 21:51:21 UTC) #2
bshe
On 2016/11/17 21:51:21, mthiesse wrote: > PTAL lgtm
4 years, 1 month ago (2016-11-17 22:03:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516453002/20001
4 years, 1 month ago (2016-11-18 15:41:53 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-18 16:19:50 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 16:22:25 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4ebc409e6f3e818512ebd0231cf9222e5d9400d3
Cr-Commit-Position: refs/heads/master@{#433214}

Powered by Google App Engine
This is Rietveld 408576698