Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2516433005: Fix histogram pid value (Closed)

Created:
4 years, 1 month ago by Rick Byers
Modified:
4 years ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix histogram pid value Use GetUniqueIdForProcess instead of GetCurrentProcId which is always 1 on Linux. BUG=666912 Committed: https://crrev.com/6a25fa4d84368bc2316a3291e3acd4b8f493e724 Cr-Commit-Position: refs/heads/master@{#434522}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/metrics/histogram_base.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
Rick Byers
isherman@ PTAL at this trivial patch
4 years, 1 month ago (2016-11-19 16:27:41 UTC) #6
Ilya Sherman
LGTM. I didn't really realize that we had this code :/ I wonder whether it's ...
4 years, 1 month ago (2016-11-21 18:25:27 UTC) #7
Rick Byers
On 2016/11/21 18:25:27, Ilya Sherman wrote: > LGTM. I didn't really realize that we had ...
4 years, 1 month ago (2016-11-23 01:07:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516433005/1
4 years ago (2016-11-25 15:09:46 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-25 16:24:48 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-25 16:27:29 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a25fa4d84368bc2316a3291e3acd4b8f493e724
Cr-Commit-Position: refs/heads/master@{#434522}

Powered by Google App Engine
This is Rietveld 408576698