Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2516433004: Add wrapper shell script to invoke dartk with checked-in binary (Closed)

Created:
4 years, 1 month ago by kustermann
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add wrapper shell script to invoke dartk with checked-in binary R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/13f7e93c7eeb67753f5f3eca3d94d2253317beba

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
A tools/dartk_wrappers/dartk View 1 chunk +19 lines, -0 lines 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 5 (2 generated)
kustermann
https://codereview.chromium.org/2516433004/diff/1/tools/testing/dart/compiler_configuration.dart File tools/testing/dart/compiler_configuration.dart (right): https://codereview.chromium.org/2516433004/diff/1/tools/testing/dart/compiler_configuration.dart#newcode220 tools/testing/dart/compiler_configuration.dart:220: return 'tools/dartk_wrappers/dartk$executableScriptSuffix'; At some point we will add a ...
4 years, 1 month ago (2016-11-18 16:32:39 UTC) #2
Vyacheslav Egorov (Google)
lgtm
4 years, 1 month ago (2016-11-18 16:34:48 UTC) #3
kustermann
4 years, 1 month ago (2016-11-18 16:35:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
13f7e93c7eeb67753f5f3eca3d94d2253317beba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698