Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2516413002: Add logic to disable default gpu dimension. (Closed)

Created:
4 years, 1 month ago by ghost stip (do not use)
Modified:
3 years, 11 months ago
Reviewers:
dtu, eyaich1
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add logic to disable default gpu dimension. BUG=663372

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/perf/generate_perf_json.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ghost stip (do not use)
ptal. I'm pretty sure this will make CLs like https://codereview.chromium.org/2514243003/ go smoothly
4 years, 1 month ago (2016-11-21 16:31:23 UTC) #3
eyaich1
On 2016/11/21 16:31:23, stip wrote: > ptal. I'm pretty sure this will make CLs like ...
4 years, 1 month ago (2016-11-21 16:34:20 UTC) #4
ghost stip (do not use)
I can't actually run the script due to https://bugs.chromium.org/p/chromium/issues/detail?id=667435. I think we *do* actually want ...
4 years, 1 month ago (2016-11-21 19:42:07 UTC) #5
eyaich1
4 years, 1 month ago (2016-11-21 19:42:49 UTC) #6
On 2016/11/21 19:42:07, stip wrote:
> I can't actually run the script due to
> https://bugs.chromium.org/p/chromium/issues/detail?id=667435.
> 
> I think we *do* actually want to have null values in here, as that is where
this
> logic kicks in:
>
https://chromium.googlesource.com/chromium/tools/build/+/refs/heads/master/sc....
> 
> We can actually try this out with a tryjob, let me cook one up.

cd into tools/perf the timing file is in that dir not in src.  Sorry about that.
 Updated the bug you filed, should be fixed soon.

Powered by Google App Engine
This is Rietveld 408576698