Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25164005: Merge 158408 "Revert 157959 "Introduce a new reference graph to ..." (Closed)

Created:
7 years, 2 months ago by inferno
Modified:
7 years, 2 months ago
Reviewers:
kouhei (in TOK)
CC:
blink-reviews, shans, adamk+blink_chromium.org, pdr, Steve Block, dino_apple.com, do-not-use, Nils Barth (inactive), kojih, alancutter (OOO until 2018), dstockwell, abarth-chromium, marja+watch_chromium.org, Timothy Loh, Eric Willigers, rjwright, darktears, haraken, Nate Chapin, jsbell+bindings_chromium.org, Mike Lawther (Google), f(malita), Stephen Chennney
Visibility:
Public.

Description

Merge 158408 "Revert 157959 "Introduce a new reference graph to ..." > Revert 157959 "Introduce a new reference graph to SVG*TearOffs." > Revert 158014 "Hold onto contextElement() from SVGAnimated* wrap..." > > TBR=pdr@chromium.org,haraken@chromium.org > BUG=270000 > BUG=294464 > > Review URL: https://chromiumcodereview.appspot.com/24863002 TBR=kouhei@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158537

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -204 lines) Patch
D LayoutTests/svg/dom/SVGListPropertyTearOff-gccrash.html View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/svg/dom/SVGListPropertyTearOff-gccrash-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/svg/dom/SVGListPropertyTearOff-leaks.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/svg/dom/SVGListPropertyTearOff-leaks-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/bindings/scripts/code_generator_v8.pm View 3 chunks +1 line, -26 lines 0 comments Download
M Source/core/svg/SVGAnimateElement.cpp View 3 chunks +0 lines, -7 lines 0 comments Download
M Source/core/svg/SVGAnimateMotionElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAnimateMotionElement.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/properties/SVGAnimatedListPropertyTearOff.h View 3 chunks +7 lines, -25 lines 0 comments Download
M Source/core/svg/properties/SVGAnimatedProperty.h View 4 chunks +4 lines, -9 lines 0 comments Download
M Source/core/svg/properties/SVGAnimatedProperty.cpp View 1 chunk +6 lines, -25 lines 0 comments Download
M Source/core/svg/properties/SVGListPropertyTearOff.h View 7 chunks +4 lines, -24 lines 0 comments Download
M Source/core/svg/properties/SVGPathSegListPropertyTearOff.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/svg/properties/SVGPropertyTearOff.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/svg/properties/SVGStaticListPropertyTearOff.h View 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
inferno
7 years, 2 months ago (2013-09-30 14:40:34 UTC) #1
inferno
Committed patchset #1 manually as r158537.
7 years, 2 months ago (2013-09-30 14:40:55 UTC) #2
kouhei (in TOK)
7 years, 2 months ago (2013-09-30 14:42:56 UTC) #3
Message was sent while issue was closed. 
On 2013/09/30 14:40:55, inferno wrote:
> Committed patchset #1 manually as r158537.

lgtm

Powered by Google App Engine
This is Rietveld 408576698