Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Unified Diff: skia/ext/benchmarking_canvas.cc

Issue 2516363005: Inline StringValue into base::Value (Closed)
Patch Set: Rebase and Nits. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: skia/ext/benchmarking_canvas.cc
diff --git a/skia/ext/benchmarking_canvas.cc b/skia/ext/benchmarking_canvas.cc
index d66614a7343d5d458d747b07a568c93d15598852..3e3602d54cd752d02174b64fc3def2c3dbfe297f 100644
--- a/skia/ext/benchmarking_canvas.cc
+++ b/skia/ext/benchmarking_canvas.cc
@@ -121,7 +121,7 @@ std::unique_ptr<base::Value> AsValue(SkBlendMode mode) {
std::unique_ptr<base::StringValue> val(
new base::StringValue(SkBlendMode_Name(mode)));
- return std::move(val);
+ return val;
}
std::unique_ptr<base::Value> AsValue(SkCanvas::PointMode mode) {
@@ -131,7 +131,7 @@ std::unique_ptr<base::Value> AsValue(SkCanvas::PointMode mode) {
std::unique_ptr<base::StringValue> val(
new base::StringValue(gModeStrings[mode]));
- return std::move(val);
+ return val;
}
std::unique_ptr<base::Value> AsValue(const SkColorFilter& filter) {
@@ -261,7 +261,7 @@ std::unique_ptr<base::Value> SaveLayerFlagsAsValue(
std::unique_ptr<base::StringValue> val(new base::StringValue(builder.str()));
- return std::move(val);
+ return val;
}
std::unique_ptr<base::Value> AsValue(SkClipOp op) {
@@ -276,7 +276,7 @@ std::unique_ptr<base::Value> AsValue(SkClipOp op) {
DCHECK_LT(index, SK_ARRAY_COUNT(gOpStrings));
std::unique_ptr<base::StringValue> val(
new base::StringValue(gOpStrings[index]));
- return std::move(val);
+ return val;
}
std::unique_ptr<base::Value> AsValue(const SkRegion& region) {
« no previous file with comments | « extensions/browser/api/idle/idle_manager.h ('k') | third_party/libaddressinput/chromium/chrome_storage_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698