chrome/browser/extensions/api/streams_private/streams_private_api.cc - Issue 2516363005: Inline StringValue into base::Value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/streams_private/streams_private_api.cc

Issue 2516363005: Inline StringValue into base::Value (Closed)

Patch Set: Rebase and Nits. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/settings/system_settings_provider.h ('k') | chrome/browser/ui/webui/options/manage_profile_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/streams_private/streams_private_api.cc

diff --git a/chrome/browser/extensions/api/streams_private/streams_private_api.cc b/chrome/browser/extensions/api/streams_private/streams_private_api.cc

index dc12dac808f754a699567fba4e96c960674587f7..21c333a6738cd3106a98121d365946cac210298b 100644

--- a/chrome/browser/extensions/api/streams_private/streams_private_api.cc

+++ b/chrome/browser/extensions/api/streams_private/streams_private_api.cc

@@ -37,9 +37,8 @@ void CreateResponseHeadersDictionary(const net::HttpResponseHeaders* headers,

while (headers->EnumerateHeaderLines(&iter, &header_name, &header_value)) {

base::Value* existing_value = NULL;

if (result->Get(header_name, &existing_value)) {

- base::StringValue* existing_string_value =

- static_cast<base::StringValue*>(existing_value);

- existing_string_value->GetString()->append(", ").append(header_value);

+ *existing_value =

+ base::Value(existing_value->GetString() + ", " + header_value);

} else {

result->SetString(header_name, header_value);

}