Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: chromeos/network/network_state_unittest.cc

Issue 2516363005: Inline StringValue into base::Value (Closed)
Patch Set: GetString by ref and TestStringValue Fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_state_unittest.cc
diff --git a/chromeos/network/network_state_unittest.cc b/chromeos/network/network_state_unittest.cc
index 6cd28ae6adf866d55b843c921a56f0ec6f78d86d..5fdb1d62df3cc34232a323a90a0ddebd2a344829 100644
--- a/chromeos/network/network_state_unittest.cc
+++ b/chromeos/network/network_state_unittest.cc
@@ -27,7 +27,11 @@ class TestStringValue : public base::Value {
explicit TestStringValue(const std::string& in_value)
: base::Value(Type::STRING), value_(in_value) {}
- ~TestStringValue() override {}
+ ~TestStringValue() override {
+ // Ugly hack that prevents ~Value() from trying to destroy string_value_.
+ // TODO(crbug.com/646113): Clean this up when StringValue will be removed.
+ type_ = Type::NONE;
+ }
// Overridden from Value:
bool GetAsString(std::string* out_value) const override {

Powered by Google App Engine
This is Rietveld 408576698