Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 2516353003: Stop checking that FilePathWatcher is used from a MessageLoopForIO. (Closed)

Created:
4 years, 1 month ago by fdoray
Modified:
4 years ago
Reviewers:
dcheng
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop checking that FilePathWatcher is used from a MessageLoopForIO. No FilePathWatcher implementation requires to be used from a MessageLoopForIO. BUG=650723 Committed: https://crrev.com/9ee0332133b606f70eadecdbf420e3afe9778055 Cr-Commit-Position: refs/heads/master@{#434205}

Patch Set 1 #

Patch Set 2 : remove patch dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M base/files/file_path_watcher_fsevents.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M base/files/file_path_watcher_linux.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
fdoray
PTAL
4 years, 1 month ago (2016-11-22 13:18:40 UTC) #6
dcheng
lgtm
4 years ago (2016-11-22 18:32:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516353003/20001
4 years ago (2016-11-23 16:34:16 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-23 18:30:05 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-23 18:34:15 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9ee0332133b606f70eadecdbf420e3afe9778055
Cr-Commit-Position: refs/heads/master@{#434205}

Powered by Google App Engine
This is Rietveld 408576698