content/browser/service_worker/service_worker_response_info.cc - Issue 2516353002: Introduce url_list to the Response scheme of CacheStorage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_response_info.cc

Issue 2516353002: Introduce url_list to the Response scheme of CacheStorage. (Closed)

Patch Set: implicit conversion WebURL <-> GURL and WebVector <- vector Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_response_info.h ('k') | content/browser/service_worker/service_worker_url_request_job.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_response_info.cc

diff --git a/content/browser/service_worker/service_worker_response_info.cc b/content/browser/service_worker/service_worker_response_info.cc

index 7ddfceb1a0d3a73c40c69eb281a764cf46131ac6..88cdb2d07a83946e6fd24295322932cfd5478008 100644

--- a/content/browser/service_worker/service_worker_response_info.cc

+++ b/content/browser/service_worker/service_worker_response_info.cc

@@ -44,8 +44,7 @@ void ServiceWorkerResponseInfo::GetExtraResponseInfo(

response_info->was_fetched_via_foreign_fetch = was_fetched_via_foreign_fetch_;

response_info->was_fallback_required_by_service_worker =

was_fallback_required_;

- response_info->original_url_via_service_worker =

- original_url_via_service_worker_;

+ response_info->url_list_via_service_worker = url_list_via_service_worker_;

response_info->response_type_via_service_worker =

response_type_via_service_worker_;

response_info->service_worker_start_time = service_worker_start_time_;

@@ -71,7 +70,7 @@ void ServiceWorkerResponseInfo::OnStartCompleted(

bool was_fetched_via_service_worker,

bool was_fetched_via_foreign_fetch,

bool was_fallback_required,

- const GURL& original_url_via_service_worker,

+ const std::vector<GURL>& url_list_via_service_worker,

blink::WebServiceWorkerResponseType response_type_via_service_worker,

base::TimeTicks service_worker_start_time,

base::TimeTicks service_worker_ready_time,

@@ -81,7 +80,7 @@ void ServiceWorkerResponseInfo::OnStartCompleted(

was_fetched_via_service_worker_ = was_fetched_via_service_worker;

was_fetched_via_foreign_fetch_ = was_fetched_via_foreign_fetch;

was_fallback_required_ = was_fallback_required;

- original_url_via_service_worker_ = original_url_via_service_worker;

+ url_list_via_service_worker_ = url_list_via_service_worker;

response_type_via_service_worker_ = response_type_via_service_worker;

response_is_in_cache_storage_ = response_is_in_cache_storage;

response_cache_storage_cache_name_ = response_cache_storage_cache_name;

@@ -98,7 +97,7 @@ void ServiceWorkerResponseInfo::ResetData() {

was_fetched_via_service_worker_ = false;

was_fetched_via_foreign_fetch_ = false;

was_fallback_required_ = false;

- original_url_via_service_worker_ = GURL();

+ url_list_via_service_worker_.clear();

response_type_via_service_worker_ =

blink::WebServiceWorkerResponseTypeDefault;

response_is_in_cache_storage_ = false;