Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: content/browser/cache_storage/cache_storage_manager_unittest.cc

Issue 2516353002: Introduce url_list to the Response scheme of CacheStorage. (Closed)
Patch Set: implicit conversion WebURL <-> GURL and WebVector <- vector Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/cache_storage/cache_storage_manager_unittest.cc
diff --git a/content/browser/cache_storage/cache_storage_manager_unittest.cc b/content/browser/cache_storage/cache_storage_manager_unittest.cc
index 90601a61139287f68e553ee359318b311596a198..6ebb69cbe4276be4a7abff4baca0312aee8857a2 100644
--- a/content/browser/cache_storage/cache_storage_manager_unittest.cc
+++ b/content/browser/cache_storage/cache_storage_manager_unittest.cc
@@ -284,14 +284,19 @@ class CacheStorageManagerTest : public testing::Test {
std::unique_ptr<storage::BlobDataHandle> blob_handle =
blob_storage_context_->AddFinishedBlob(blob_data.get());
+ std::unique_ptr<std::vector<GURL>> url_list =
+ base::MakeUnique<std::vector<GURL>>();
+ url_list->push_back(request.url);
ServiceWorkerResponse response(
- request.url, status_code, "OK",
- blink::WebServiceWorkerResponseTypeDefault, response_headers,
+ std::move(url_list), status_code, "OK",
+ blink::WebServiceWorkerResponseTypeDefault,
+ base::MakeUnique<ServiceWorkerHeaderMap>(response_headers),
blob_handle->uuid(), request.url.spec().size(), GURL(),
blink::WebServiceWorkerResponseErrorUnknown, base::Time(),
false /* is_in_cache_storage */,
std::string() /* cache_storage_cache_name */,
- ServiceWorkerHeaderList() /* cors_exposed_header_names */);
+ base::MakeUnique<
+ ServiceWorkerHeaderList>() /* cors_exposed_header_names */);
CacheStorageBatchOperation operation;
operation.operation_type = CACHE_STORAGE_CACHE_OPERATION_TYPE_PUT;

Powered by Google App Engine
This is Rietveld 408576698